From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Holt Subject: Re: [PATCH v11 6/6] powerpc: Add flexcan device support for p1010rdb. Date: Thu, 11 Aug 2011 11:48:13 -0500 Message-ID: <20110811164813.GF4926@sgi.com> References: <1313078831-2511-1-git-send-email-holt@sgi.com> <1313078831-2511-7-git-send-email-holt@sgi.com> <4E4404BC.7060502@grandegger.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, U Bhaskar-B22300 , Kumar Gala , Grant Likely , Marc Kleine-Budde , Scott Wood , PPC list To: Wolfgang Grandegger Return-path: Content-Disposition: inline In-Reply-To: <4E4404BC.7060502-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org On Thu, Aug 11, 2011 at 06:35:08PM +0200, Wolfgang Grandegger wrote: > On 08/11/2011 06:07 PM, Robin Holt wrote: > > Allow the p1010 processor to select the flexcan network driver. > > > > Signed-off-by: Robin Holt > > Acked-by: Marc Kleine-Budde , > > Acked-by: Wolfgang Grandegger , > > Cc: U Bhaskar-B22300 > > Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, > > Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, > > Cc: PPC list > > Cc: Kumar Gala > > --- > > arch/powerpc/boot/dts/p1010rdb.dts | 8 ++++++++ > > arch/powerpc/platforms/85xx/Kconfig | 2 ++ > > 2 files changed, 10 insertions(+), 0 deletions(-) > > > > diff --git a/arch/powerpc/boot/dts/p1010rdb.dts b/arch/powerpc/boot/dts/p1010rdb.dts > > index d6c669c..df89b60 100644 > > --- a/arch/powerpc/boot/dts/p1010rdb.dts > > +++ b/arch/powerpc/boot/dts/p1010rdb.dts > > @@ -171,6 +171,14 @@ > > }; > > }; > > > > + can@1c000 { > > + clock-frequency = <0x0bebc1fc>; > > + }; > > > clock-frequency = <200000000>; // filled in by boot-loader > > Is better readable and makes clear that the value is filled in by the > boot loader. Usually we specify "<0>" in that case but it will *not* > work with your board because U-Boot fills into the property "clock_freq" > the CCB-frequency, which is twice as much. This needs to be fixed. I guess the question then is, should I not add the clock-frequency to this file and let this fall back upon the boot-loader? Until the boot loader is up-to-speed, my test .dts file will need to define it. Thanks, Robin > > > + can1: can@1d000 { > > What is the "can1:" good for? > > > + clock-frequency = <0x0bebc1fc>; > > See above. > > Wolfgang. > > > > > > usb@22000 { > > phy_type = "utmi"; > > }; > > diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig > > index 498534c..c4304ae 100644 > > --- a/arch/powerpc/platforms/85xx/Kconfig > > +++ b/arch/powerpc/platforms/85xx/Kconfig > > @@ -70,6 +70,8 @@ config MPC85xx_RDB > > config P1010_RDB > > bool "Freescale P1010RDB" > > select DEFAULT_UIMAGE > > + select HAVE_CAN_FLEXCAN if NET && CAN > > + select PPC_CLOCK if CAN_FLEXCAN > > help > > This option enables support for the MPC85xx RDB (P1010 RDB) board > >