From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Holt Subject: Re: [PATCH v11 6/6] powerpc: Add flexcan device support for p1010rdb. Date: Thu, 11 Aug 2011 13:12:58 -0500 Message-ID: <20110811181258.GG4926@sgi.com> References: <1313078831-2511-1-git-send-email-holt@sgi.com> <1313078831-2511-7-git-send-email-holt@sgi.com> <9C81E6C0-D278-40BF-8F32-445F870F845A@kernel.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, U Bhaskar-B22300 , socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, Scott Wood , PPC list To: Kumar Gala Return-path: Content-Disposition: inline In-Reply-To: <9C81E6C0-D278-40BF-8F32-445F870F845A-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org On Thu, Aug 11, 2011 at 12:41:34PM -0500, Kumar Gala wrote: > > On Aug 11, 2011, at 11:07 AM, Robin Holt wrote: > > > Allow the p1010 processor to select the flexcan network driver. > > > > Signed-off-by: Robin Holt > > Acked-by: Marc Kleine-Budde , > > Acked-by: Wolfgang Grandegger , > > Cc: U Bhaskar-B22300 > > Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, > > Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, > > Cc: PPC list > > Cc: Kumar Gala > > --- > > arch/powerpc/boot/dts/p1010rdb.dts | 8 ++++++++ > > arch/powerpc/platforms/85xx/Kconfig | 2 ++ > > 2 files changed, 10 insertions(+), 0 deletions(-) > > > > diff --git a/arch/powerpc/boot/dts/p1010rdb.dts b/arch/powerpc/boot/dts/p1010rdb.dts > > index d6c669c..df89b60 100644 > > --- a/arch/powerpc/boot/dts/p1010rdb.dts > > +++ b/arch/powerpc/boot/dts/p1010rdb.dts > > @@ -171,6 +171,14 @@ > > }; > > }; > > > > + can@1c000 { > > + clock-frequency = <0x0bebc1fc>; > > + }; > > + > > + can1: can@1d000 { > > + clock-frequency = <0x0bebc1fc>; > > + }; > > + > > set them to 0, as we expect u-boot to fill them in. Done. > > > usb@22000 { > > phy_type = "utmi"; > > }; > > diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig > > index 498534c..c4304ae 100644 > > --- a/arch/powerpc/platforms/85xx/Kconfig > > +++ b/arch/powerpc/platforms/85xx/Kconfig > > @@ -70,6 +70,8 @@ config MPC85xx_RDB > > config P1010_RDB > > bool "Freescale P1010RDB" > > select DEFAULT_UIMAGE > > + select HAVE_CAN_FLEXCAN if NET && CAN > > + select PPC_CLOCK if CAN_FLEXCAN > > Can you move this to arch/powerpc/Kconfig & FSL_SOC instead. I am not sure. FSL_SOC seems to come with any of the freescale system on a chip. I would not be that worried, about the flexcan build as I think that is sufficiently agostic where we will not see problems, but now we could end up with build failures on any of the other configs which select CAN_FLEXCAN. I would normally want to do all those builds, but there is no way I would know how to do that with my limited knowledge of powerpc and freescale. If you are comfortable with that, I will happily make the change. Thanks, Robin