netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: ja@ssi.bg, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] neigh: reduce arp latency
Date: Fri, 12 Aug 2011 02:57:08 -0700 (PDT)	[thread overview]
Message-ID: <20110812.025708.1569052368114569085.davem@davemloft.net> (raw)
In-Reply-To: <1312913758.2547.8.camel@edumazet-laptop>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 09 Aug 2011 20:15:58 +0200

> Le mardi 09 août 2011 à 20:06 +0300, Julian Anastasov a écrit :
> 
>> 	To be correct with old NUD_INCOMPLETE logic may be we can use 
>> max(neigh->parms->retrans_time, HZ/2) here instead of HZ?
>> 
> 
> Thanks Julian a lot for reviewing, here is v2 adressing this point.
> 
> [PATCH v2 net-next] neigh: reduce arp latency
> 
> Remove the artificial HZ latency on arp resolution.
> 
> Instead of firing a timer in one jiffy (up to 10 ms if HZ=100), lets
> send the ARP message immediately.
> 
> Before patch :
> 
> # arp -d 192.168.20.108 ; ping -c 3 192.168.20.108
> PING 192.168.20.108 (192.168.20.108) 56(84) bytes of data.
> 64 bytes from 192.168.20.108: icmp_seq=1 ttl=64 time=9.91 ms
> 64 bytes from 192.168.20.108: icmp_seq=2 ttl=64 time=0.065 ms
> 64 bytes from 192.168.20.108: icmp_seq=3 ttl=64 time=0.061 ms
> 
> After patch :
> 
> $ arp -d 192.168.20.108 ; ping -c 3 192.168.20.108
> PING 192.168.20.108 (192.168.20.108) 56(84) bytes of data.
> 64 bytes from 192.168.20.108: icmp_seq=1 ttl=64 time=0.152 ms
> 64 bytes from 192.168.20.108: icmp_seq=2 ttl=64 time=0.064 ms
> 64 bytes from 192.168.20.108: icmp_seq=3 ttl=64 time=0.074 ms
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

Applied.

      reply	other threads:[~2011-08-12  9:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-09 15:40 [PATCH net-next] neigh: reduce arp latency Eric Dumazet
2011-08-09 17:06 ` Julian Anastasov
2011-08-09 18:15   ` [PATCH v2 " Eric Dumazet
2011-08-12  9:57     ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110812.025708.1569052368114569085.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=ja@ssi.bg \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).