From: Arnd Bergmann <arnd@arndb.de>
To: Jason Baron <jbaron@redhat.com>
Cc: gregkh@suse.de, joe@perches.com, jim.cromie@gmail.com,
bvanassche@acm.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, aloisio.almeida@openbossa.org,
netdev@vger.kernel.org
Subject: [PATCH ] dynamic_debug: call __netdev_printk only for CONFIG_NET
Date: Thu, 1 Sep 2011 16:57:02 +0200 [thread overview]
Message-ID: <201109011657.02407.arnd@arndb.de> (raw)
In-Reply-To: <5514795fe63ccfd4b3a80283ed04a526abe3c59d.1313085588.git.jbaron@redhat.com>
__netdev_printk is only defined when CONFIG_NET is set. Since we only need
__dynamic_netdev_dbg for network drivers, we can make it conditional on the
same Kconfig symbol.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
On Thursday 11 August 2011, Jason Baron wrote:
>
> From: Jason Baron <jbaron@redhat.com>
>
> Previously, if dynamic debug was enabled netdev_dbg() was using
> dynamic_dev_dbg() to print out the underlying msg. Fix this by making
> sure netdev_dbg() uses __netdev_printk().
>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Jason Baron <jbaron@redhat.com>
> ---
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -504,6 +504,7 @@ int __dynamic_dev_dbg(struct _ddebug *descriptor,
}
EXPORT_SYMBOL(__dynamic_dev_dbg);
+#ifdef CONFIG_NET
int __dynamic_netdev_dbg(struct _ddebug *descriptor,
const struct net_device *dev, const char *fmt, ...)
{
@@ -527,6 +528,7 @@ int __dynamic_netdev_dbg(struct _ddebug *descriptor,
return res;
}
EXPORT_SYMBOL(__dynamic_netdev_dbg);
+#endif
static __initdata char ddebug_setup_string[1024];
static __init int ddebug_setup_query(char *str)
next prev parent reply other threads:[~2011-09-01 14:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 18:36 [PATCH 00/11] various fixes v3 Jason Baron
2011-08-11 18:36 ` [PATCH 01/11] dynamic_debug: Add __dynamic_dev_dbg Jason Baron
2011-08-11 18:36 ` [PATCH 07/11] dynamic_debug: make netdev_dbg() call __netdev_printk() Jason Baron
2011-09-01 14:57 ` Arnd Bergmann [this message]
2011-09-01 15:18 ` [PATCH ] dynamic_debug: call __netdev_printk only for CONFIG_NET Jason Baron
2011-09-18 8:27 ` Greg KH
2011-09-18 17:21 ` Randy Dunlap
2011-09-18 18:27 ` Greg KH
2011-09-18 18:42 ` Randy Dunlap
2011-09-19 13:48 ` Jason Baron
2011-09-19 16:49 ` Randy Dunlap
2011-08-11 18:36 ` [PATCH 08/11] dynamic_debug: make netif_dbg() call __netdev_printk() Jason Baron
2011-08-23 1:32 ` [PATCH 00/11] various fixes v3 Greg KH
2011-08-23 13:54 ` Jason Baron
2011-08-23 15:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109011657.02407.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=aloisio.almeida@openbossa.org \
--cc=bvanassche@acm.org \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=jbaron@redhat.com \
--cc=jim.cromie@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).