From: David Miller <davem@davemloft.net>
To: zheng.z.yan@intel.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH] tcp: fix validation of D-SACK
Date: Sun, 18 Sep 2011 22:37:44 -0400 (EDT) [thread overview]
Message-ID: <20110918.223744.2195272571175354579.davem@davemloft.net> (raw)
In-Reply-To: <4E76A36B.4060109@intel.com>
From: "Yan, Zheng" <zheng.z.yan@intel.com>
Date: Mon, 19 Sep 2011 10:05:31 +0800
> D-SACK is allowed to reside below snd_una. But the corresponding check
> in tcp_is_sackblock_valid() is the exact opposite. It looks like a typo.
>
> Signed-off-by: Zheng Yan <zheng.z.yan@intel.com>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks.
next prev parent reply other threads:[~2011-09-19 2:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 1:45 [BUG?] tcp: potential bug in tcp_is_sackblock_valid() Yan, Zheng
2011-09-09 1:54 ` Herbert Xu
2011-09-09 2:10 ` Yan, Zheng
2011-09-09 8:03 ` Ilpo Järvinen
[not found] ` <CAA93jw7L9KyXVevZ8dqE+ExLYP9=CLMmj1gPD88ihBuC6ZovOQ@mail.gmail.com>
2011-09-18 20:39 ` Eric Dumazet
2011-09-18 21:04 ` Dave Taht
2011-09-18 21:20 ` Hagen Paul Pfeifer
2011-09-18 19:35 ` Eric Dumazet
2011-09-19 1:07 ` David Miller
2011-09-19 2:05 ` [PATCH] tcp: fix validation of D-SACK Yan, Zheng
2011-09-19 2:37 ` David Miller [this message]
2011-09-19 17:29 ` Jan Ceuleers
2011-09-20 18:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110918.223744.2195272571175354579.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).