From: Kim Phillips <kim.phillips@freescale.com>
To: <stable@kernel.org>
Cc: <eric.dumazet@gmail.com>, <zheng.z.yan@intel.com>,
<netdev@vger.kernel.org>, David Miller <davem@davemloft.net>
Subject: Re: [PATCH] ipv4: fix ipsec forward performance regression
Date: Tue, 1 Nov 2011 18:50:22 -0500 [thread overview]
Message-ID: <20111101185022.b156ea957baf286f1bf00f9c@freescale.com> (raw)
In-Reply-To: <20111024.030203.404195331212003955.davem@davemloft.net>
On Mon, 24 Oct 2011 03:02:03 -0400
David Miller <davem@davemloft.net> wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Sun, 23 Oct 2011 11:03:10 +0200
>
> > Le dimanche 23 octobre 2011 à 15:58 +0800, Yan, Zheng a écrit :
> >> There is bug in commit 5e2b61f(ipv4: Remove flowi from struct rtable).
> >> It makes xfrm4_fill_dst() modify wrong data structure.
> >>
> >> Signed-off-by: Zheng Yan <zheng.z.yan@intel.com>
> ...
> > Reported-by: Kim Phillips <kim.phillips@freescale.com>
> >
> > Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> Applied, thanks everyone.
To: <stable@kernel.org>
-stable maintainers, please consider the following two upstream
commits for inclusion in upcoming v3.0.x [1] stable releases:
v3.0.8 plus this:
upstream commit b73233960a59ee66e09d642f13d0592b13651e94
(ipv4: fix ipsec forward performance regression)
increases IPSec fwding performance from 0.2kpps to ~3.5kpps.
Adding this:
upstream commit aa1c366e4febc7f5c2b84958a2dd7cd70e28f9d0
(net: Handle different key sizes between address families in flow
cache)
to that, brings it back up to 2.6.38 levels, i.e., ~44kpps.
note that for v2.6.39.4 (.39 is the first kernel version with the
40->0.2kpps regression), commit b732339 depends on a slew of
commits, presumably ending with commit 5e2b61f: ipv4: Remove flowi
from struct rtable.
However it appears commit aa1c366e alone will restore almost all
the performance (~42kpps) on that kernel version.
So to summarize, please cherry-pick:
v2.6.39.x: aa1c366: net: Handle different key sizes between address families in flow cache
v3.0.x: aa1c366: net: Handle different key sizes between address families in flow cache
v3.0.x: b732339: ipv4: fix ipsec forward performance regression
v3.1.x: b732339: ipv4: fix ipsec forward performance regression
[All figures are based on a p2020ds board configured to rx, encrypt
and forward 64-byte packets.]
Thanks,
Kim
[1] initial kernel in long-term stable series for the embedded
industry (http://lwn.net/Articles/464834/)
next prev parent reply other threads:[~2011-11-01 23:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-23 7:58 [PATCH] ipv4: fix ipsec forward performance regression Yan, Zheng
2011-10-23 9:03 ` Eric Dumazet
2011-10-24 7:02 ` David Miller
2011-11-01 23:50 ` Kim Phillips [this message]
2011-11-02 0:34 ` David Miller
2011-11-03 18:58 ` Kim Phillips
2011-11-04 2:43 ` David Miller
2011-11-04 19:46 ` [stable] net: Handle different key sizes between address families in flow cache Kim Phillips
2011-11-04 20:41 ` David Miller
2011-11-04 21:24 ` Greg KH
2011-11-05 2:29 ` Kim Phillips
2011-11-08 16:53 ` Greg KH
2011-11-08 19:44 ` [stable v2] " Kim Phillips
2011-10-23 14:52 ` [PATCH] ipv4: fix ipsec forward performance regression Julian Anastasov
2011-10-24 0:41 ` Yan, Zheng
2011-10-24 7:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111101185022.b156ea957baf286f1bf00f9c@freescale.com \
--to=kim.phillips@freescale.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).