From: Stephen Hemminger <shemminger@vyatta.com>
To: David Decotigny <david.decotigny@google.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Ian Campbell <ian.campbell@citrix.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Jiri Pirko <jpirko@redhat.com>, Joe Perches <joe@perches.com>,
Szymon Janc <szymon@janc.net.pl>, Mandeep Baines <msb@google.com>
Subject: Re: [PATCH net v2 1/8] forcedeth: Improve stats counters
Date: Fri, 4 Nov 2011 07:54:14 -0700 [thread overview]
Message-ID: <20111104075414.3f674ba8@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <f005f434ebc4922bbcc1b7bf6949bb3b7c45fbe8.1320369398.git.david.decotigny@google.com>
On Thu, 3 Nov 2011 18:41:16 -0700
David Decotigny <david.decotigny@google.com> wrote:
> From: Mandeep Baines <msb@google.com>
>
> Rx byte count was off; instead use the hardware's count. Tx packet
> count was counting pre-TSO packets; instead count on-the-wire packets.
> Report hardware dropped frame count as rx_fifo_errors.
>
> - The count of transmitted packets reported by the forcedeth driver
> reports pre-TSO (TCP Segmentation Offload) packet counts and not the
> count of the number of packets sent on the wire. This change fixes
> the forcedeth driver to report the correct count. Fixed the code by
> copying the count stored in the NIC H/W to the value reported by the
> driver.
>
> - Count rx_drop_frame errors as rx_fifo_errors:
> We see a lot of rx_drop_frame errors if we disable the rx bottom-halves
> for too long. Normally, rx_fifo_errors would be counted in this case.
> The rx_drop_frame error count is private to forcedeth and is not
> reported by ifconfig or sysfs. The rx_fifo_errors count is currently
> unused in the forcedeth driver. It is reported by ifconfig as overruns.
> This change reports rx_drop_frame errors as rx_fifo_errors.
>
>
>
> Signed-off-by: David Decotigny <david.decotigny@google.com>
> ---
> drivers/net/ethernet/nvidia/forcedeth.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c
> index 1e37eb9..64b1c7c 100644
> --- a/drivers/net/ethernet/nvidia/forcedeth.c
> +++ b/drivers/net/ethernet/nvidia/forcedeth.c
> @@ -1682,6 +1682,7 @@ static void nv_get_hw_stats(struct net_device *dev)
> np->estats.tx_pause += readl(base + NvRegTxPause);
> np->estats.rx_pause += readl(base + NvRegRxPause);
> np->estats.rx_drop_frame += readl(base + NvRegRxDropFrame);
> + np->estats.rx_errors_total += np->estats.rx_drop_frame;
> }
>
> if (np->driver_data & DEV_HAS_STATISTICS_V3) {
> @@ -1706,11 +1707,14 @@ static struct net_device_stats *nv_get_stats(struct net_device *dev)
> nv_get_hw_stats(dev);
>
> /* copy to net_device stats */
> + dev->stats.tx_packets = np->estats.tx_packets;
> + dev->stats.rx_bytes = np->estats.rx_bytes;
> dev->stats.tx_bytes = np->estats.tx_bytes;
> dev->stats.tx_fifo_errors = np->estats.tx_fifo_errors;
> dev->stats.tx_carrier_errors = np->estats.tx_carrier_errors;
> dev->stats.rx_crc_errors = np->estats.rx_crc_errors;
> dev->stats.rx_over_errors = np->estats.rx_over_errors;
> + dev->stats.rx_fifo_errors = np->estats.rx_drop_frame;
> dev->stats.rx_errors = np->estats.rx_errors_total;
> dev->stats.tx_errors = np->estats.tx_errors_total;
> }
Why not convert it to 64 bit stats as well.
next prev parent reply other threads:[~2011-11-04 14:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 1:41 [PATCH net v2 0/8] forcedeth: minor fixes for stats, rmmod, sparse David Decotigny
2011-11-04 1:41 ` [PATCH net v2 1/8] forcedeth: Improve stats counters David Decotigny
2011-11-04 14:54 ` Stephen Hemminger [this message]
2011-11-04 17:17 ` David Decotigny
2011-11-04 1:41 ` [PATCH net v2 2/8] forcedeth: new ethtool stat "tx_timeout" to account for tx_timeouts David Decotigny
2011-11-04 1:41 ` [PATCH net v2 3/8] forcedeth: allow to silence tx_timeout debug messages David Decotigny
2011-11-04 1:41 ` [PATCH net v2 4/8] forcedeth: Acknowledge only interrupts that are being processed David Decotigny
2011-11-04 1:41 ` [PATCH net v2 5/8] forcedeth: Add messages to indicate using MSI or MSI-X David Decotigny
2011-11-04 1:41 ` [PATCH net v2 6/8] forcedeth: Fix a race during rmmod of forcedeth David Decotigny
2011-11-04 3:46 ` Ben Hutchings
2011-11-04 17:22 ` David Decotigny
2011-11-05 22:16 ` David Decotigny
2011-11-04 1:41 ` [PATCH net v2 7/8] forcedeth: expose module parameters in /sys/module David Decotigny
2011-11-04 1:41 ` [PATCH net v2 8/8] forcedeth: fix a few sparse warnings (variable shadowing) David Decotigny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111104075414.3f674ba8@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=david.decotigny@google.com \
--cc=eric.dumazet@gmail.com \
--cc=ian.campbell@citrix.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=msb@google.com \
--cc=netdev@vger.kernel.org \
--cc=szymon@janc.net.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).