From: David Lamparter <equinox@diac24.net>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Lamparter <equinox@diac24.net>,
netdev <netdev@vger.kernel.org>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH 1/2] net: vlan: 802.1ad S-VLAN support
Date: Mon, 7 Nov 2011 23:02:20 +0100 [thread overview]
Message-ID: <20111107220220.GD1833899@jupiter.n2.diac24.net> (raw)
In-Reply-To: <20111107134142.05d997a5@nehalam.linuxnetplumber.net>
On Mon, Nov 07, 2011 at 01:41:42PM -0800, Stephen Hemminger wrote:
> On Sat, 5 Nov 2011 17:54:14 +0100
> David Lamparter <equinox@diac24.net> wrote:
>
> > - * @h_vlan_proto: ethernet protocol (always 0x8100)
> > + * @h_vlan_proto: ethernet protocol (0x8100, 0x88a8, 0x9x00)
>
> It seems this patch is mixing stacked vlan's and the ability to
> set ethernet protocol field. Aren't the two capabilities really
> separate protocol extensions?
This patch does not affect stacked vlans at all. The "QinQ" in the
title refers to Nortel's 0x9100/0x9200/0x9300 protocol values, which
were marketed as "QinQ" (the protocol value was used to signal the
stacking depth to the switch to ease hw processing). I should
probably remove the "QinQ" label to avoid this misunderstanding.
All of those protocol values can be used in any stacking as desired.
-David
next prev parent reply other threads:[~2011-11-07 22:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-05 16:54 [PATCH net-next 0/2] 802.1ad S-VLAN support David Lamparter
2011-11-05 16:54 ` [PATCH 1/2] net: vlan: " David Lamparter
2011-11-05 17:05 ` [PATCH iproute2] link/vlan: Add 802.1ad / QinQ support David Lamparter
2011-11-07 21:41 ` [PATCH 1/2] net: vlan: 802.1ad S-VLAN support Stephen Hemminger
2011-11-07 22:02 ` David Lamparter [this message]
2011-11-07 21:44 ` Stephen Hemminger
2011-11-07 22:18 ` David Lamparter
2011-11-12 1:22 ` David Miller
2011-11-12 9:25 ` Michał Mirosław
2011-11-12 14:14 ` David Lamparter
2011-11-12 16:06 ` Michał Mirosław
2011-11-12 22:22 ` David Miller
2011-11-05 16:54 ` [PATCH 2/2] net: vlan: remove unused struct vlan_group->hlist David Lamparter
2011-11-07 15:11 ` [PATCH net-next 0/2] 802.1ad S-VLAN support Ben Hutchings
2011-11-07 15:48 ` David Lamparter
2011-11-07 21:35 ` Ben Hutchings
2011-11-07 23:07 ` David Lamparter
2011-11-08 0:16 ` Ben Hutchings
2011-11-09 15:34 ` David Lamparter
2011-11-09 23:58 ` Ben Hutchings
2011-11-07 23:18 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111107220220.GD1833899@jupiter.n2.diac24.net \
--to=equinox@diac24.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).