From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Xu Subject: Re: [PATCH 2/2] IB/ipoib: fix GRO merge failure for IPoIB originated TCP streams Date: Wed, 1 Feb 2012 19:38:37 +1100 Message-ID: <20120201083837.GA7081@gondor.apana.org.au> References: <4F264A6C.3070706@mellanox.com> <1327910672.2891.12.camel@edumazet-laptop> <20120130081849.GA7848@gondor.apana.org.au> <1327913583.2288.5.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> <20120130085742.GA8262@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Eric Dumazet , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma , Shlomo Pongratz , Roland Dreier To: Or Gerlitz Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Wed, Feb 01, 2012 at 10:23:22AM +0200, Or Gerlitz wrote: > > So what would you recommend here? not sure if you saw that, but Shlomo > suggested to add new entry to the header ops, compare_header e.g such > that if skb->dev has this callback use it instead of > compare_ether_header in __napi_gro_receive, makes sense? If we just turn it into a memcmp with a variable length would that work for you? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html