From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/3 net-next] bnx2: Add missing memory barrier in bnx2_start_xmit()
Date: Sun, 05 Feb 2012 22:46:44 -0500 (EST) [thread overview]
Message-ID: <20120205.224644.911937990752945293.davem@davemloft.net> (raw)
In-Reply-To: <1328491480-13030-2-git-send-email-mchan@broadcom.com>
From: "Michael Chan" <mchan@broadcom.com>
Date: Sun, 5 Feb 2012 17:24:39 -0800
> From: Vlad Zolotarov <vlad@scalemp.com>
>
> Sync DMA descriptor before hitting the TX mailbox for weak memory model
> CPUs.
>
> There has been discussions several years ago about this. Some believe
> that writel() should guarantee ordering. Others want explicit barriers
> if necessary. Today writel() does not have the ordering guarantee and
> many other drivers use explicit barriers.
>
> Signed-off-by: Vlad Zolotarov <vlad@scalemp.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied.
next prev parent reply other threads:[~2012-02-06 3:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 1:24 [PATCH 1/3 net-next] bnx2: Add support for ethtool --show-channels|--set-channels Michael Chan
2012-02-06 1:24 ` [PATCH 2/3 net-next] bnx2: Add missing memory barrier in bnx2_start_xmit() Michael Chan
2012-02-06 1:24 ` [PATCH 3/3 net-next] cnic: Add FCoE parity error recovery Michael Chan
2012-02-06 3:46 ` David Miller
2012-02-06 3:46 ` David Miller [this message]
2012-02-06 3:46 ` [PATCH 1/3 net-next] bnx2: Add support for ethtool --show-channels|--set-channels David Miller
2012-02-07 20:19 ` Ben Hutchings
2012-02-07 20:58 ` Michael Chan
2012-02-07 22:01 ` Ben Hutchings
2012-02-07 22:36 ` Ben Hutchings
2012-02-08 1:19 ` Jesse Brandeburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120205.224644.911937990752945293.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).