From: David Miller <davem@davemloft.net>
To: cascardo@linux.vnet.ibm.com
Cc: yevgenyp@mellanox.co.il, ogerlitz@mellanox.com,
eugenia@mellanox.co.il, alexg@mellanox.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mlx4: allow device removal by fixing dma unmap size
Date: Mon, 06 Feb 2012 14:42:49 -0500 (EST) [thread overview]
Message-ID: <20120206.144249.2096673389778792309.davem@davemloft.net> (raw)
In-Reply-To: <1328553590-27677-1-git-send-email-cascardo@linux.vnet.ibm.com>
From: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
Date: Mon, 6 Feb 2012 16:39:49 -0200
> After opening the network interface, Mellanox ConnectX device cannot be
> removed by hotplug because it has not properly unmapped all DMA memory.
>
> It happens that mlx4_en_activate_rx_rings overrides the variable that
> keeps the size of the memory mapped.
>
> This is fixed by passing to mlx4_en_destroy_rx_ring the same size that is
> given to mlx4_en_create_rx_ring.
>
> After applying this patch, hot unplugging the device works after opening
> the interface.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
Applied.
prev parent reply other threads:[~2012-02-06 19:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 18:39 [PATCH 1/2] mlx4: allow device removal by fixing dma unmap size Thadeu Lima de Souza Cascardo
2012-02-06 18:39 ` [PATCH 2/2] mlx4: fix DMA mapping leak when allocation fails Thadeu Lima de Souza Cascardo
2012-02-06 19:42 ` David Miller
2012-02-06 19:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120206.144249.2096673389778792309.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexg@mellanox.com \
--cc=cascardo@linux.vnet.ibm.com \
--cc=eugenia@mellanox.co.il \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).