From: "Henrik Rydberg" <rydberg@euromail.se>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
netdev@vger.kernel.org, Arend van Spriel <arend@broadcom.com>,
"Franky (Zhenhui) Lin" <frankyl@broadcom.com>
Subject: Re: [PATCH] bcma: don't fail for bad SPROM CRC
Date: Mon, 6 Feb 2012 18:35:32 +0100 [thread overview]
Message-ID: <20120206173532.GA5692@polaris.bitmath.org> (raw)
In-Reply-To: <CACna6rwqO73a0G=AQhTVCm=KeLRgjgc5ohJ_B8Z4T9Y-6ZTwMg@mail.gmail.com>
On Mon, Feb 06, 2012 at 06:08:51PM +0100, Rafał Miłecki wrote:
> 2012/2/6 Henrik Rydberg <rydberg@euromail.se>:
> > The brcmsmac driver is now checking the bcma SPROM CRCs, leaving some
> > chipsets unrecognized that were functional prior to the switch. In
> > particular, the current code bails out on recent Macbooks. This patch
> > simply ignores the outcome of the CRC check, with the argument that an
> > unrecognized SPROM should be treated similarly to a non-existing one.
>
> Have you maybe tried to look at the real solution?
No, this is a pure regression fix.
Henrik
next prev parent reply other threads:[~2012-02-06 17:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 13:26 [PATCH] bcma: don't fail for bad SPROM CRC Henrik Rydberg
2012-02-06 13:34 ` Arend van Spriel
2012-02-06 13:48 ` Henrik Rydberg
2012-02-06 17:08 ` Rafał Miłecki
2012-02-06 17:35 ` Henrik Rydberg [this message]
2012-02-06 19:28 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120206173532.GA5692@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=arend@broadcom.com \
--cc=frankyl@broadcom.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).