From: David Miller <davem@davemloft.net>
To: festevam@gmail.com
Cc: netdev@vger.kernel.org, netdev@pradeepdalvi.com,
kernel@pengutronix.de, fabio.estevam@freescale.com
Subject: Re: [PATCH] net: fec: Fix build due to wrong dev annotation
Date: Tue, 07 Feb 2012 13:33:07 -0500 (EST) [thread overview]
Message-ID: <20120207.133307.109701321398712057.davem@davemloft.net> (raw)
In-Reply-To: <1328639251-26310-1-git-send-email-festevam@gmail.com>
From: Fabio Estevam <festevam@gmail.com>
Date: Tue, 7 Feb 2012 16:27:31 -0200
> commit 21a4e469 (netdev: ethernet dev_alloc_skb to netdev_alloc_skb)
> should have used "ndev" instead of "dev".
>
> This causes the following build errors:
>
> drivers/net/ethernet/freescale/fec.c: In function 'fec_enet_rx':
> drivers/net/ethernet/freescale/fec.c:714: error: 'dev' undeclared (first use in this function)
> drivers/net/ethernet/freescale/fec.c:714: error: (Each undeclared identifier is reported only once
> drivers/net/ethernet/freescale/fec.c:714: error: for each function it appears in.)
> drivers/net/ethernet/freescale/fec.c: In function 'fec_enet_alloc_buffers':
> drivers/net/ethernet/freescale/fec.c:1213: error: 'dev' undeclared (first use in this function)
>
> Fix it, so that fec driver can be built again.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied, thanks.
next prev parent reply other threads:[~2012-02-07 18:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 18:27 [PATCH] net: fec: Fix build due to wrong dev annotation Fabio Estevam
2012-02-07 18:33 ` David Miller [this message]
2012-02-07 19:12 ` Pradeep A. Dalvi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120207.133307.109701321398712057.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=netdev@pradeepdalvi.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).