From: David Miller <davem@davemloft.net>
To: geert@linux-m68k.org
Cc: netdev@pradeepdalvi.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org
Subject: Re: [PATCH v5 3/5] netdev: ethernet dev_alloc_skb to netdev_alloc_skb
Date: Tue, 07 Feb 2012 15:29:05 -0500 (EST) [thread overview]
Message-ID: <20120207.152905.1412072387367320828.davem@davemloft.net> (raw)
In-Reply-To: <CAMuHMdXFz5zEWUkrJjNvOqkgt-n2uKc3wzD9H5NKKz1LT4BpOw@mail.gmail.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 7 Feb 2012 21:04:07 +0100
> drivers/net/ethernet/natsemi/sonic.c:425: error: too few arguments to
> function 'netdev_alloc_skb'
I just wrote and committed the following fix, which took less effort
than your report most likely :-)
--------------------
sonice: Fix build due to botched netdev_alloc_skb() conversion.
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
drivers/net/ethernet/natsemi/sonic.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/natsemi/sonic.c b/drivers/net/ethernet/natsemi/sonic.c
index 0452e296..46795e4 100644
--- a/drivers/net/ethernet/natsemi/sonic.c
+++ b/drivers/net/ethernet/natsemi/sonic.c
@@ -422,7 +422,7 @@ static void sonic_rx(struct net_device *dev)
status = sonic_rda_get(dev, entry, SONIC_RD_STATUS);
if (status & SONIC_RCR_PRX) {
/* Malloc up new buffer. */
- new_skb = netdev_alloc_skb(SONIC_RBSIZE + 2);
+ new_skb = netdev_alloc_skb(dev, SONIC_RBSIZE + 2);
if (new_skb == NULL) {
printk(KERN_ERR "%s: Memory squeeze, dropping packet.\n", dev->name);
lp->stats.rx_dropped++;
--
1.7.7.6
next prev parent reply other threads:[~2012-02-07 20:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-05 12:49 [PATCH v5 1/5] netdev: ethernet dev_alloc_skb to netdev_alloc_skb Pradeep A. Dalvi
2012-02-05 12:50 ` [PATCH v5 2/5] " Pradeep A. Dalvi
2012-02-06 16:49 ` David Miller
2012-02-06 17:40 ` Pradeep A. Dalvi
2012-02-05 12:50 ` [PATCH v5 3/5] " Pradeep A. Dalvi
2012-02-06 16:52 ` David Miller
2012-02-07 20:04 ` Geert Uytterhoeven
2012-02-07 20:29 ` David Miller [this message]
2012-02-05 12:51 ` [PATCH v5 4/5] " Pradeep A. Dalvi
2012-02-06 17:07 ` David Miller
2012-02-06 17:43 ` Pradeep A. Dalvi
2012-02-06 21:16 ` [PATCH v6 " Pradeep A Dalvi
2012-02-08 23:50 ` David Miller
2012-02-05 12:51 ` [PATCH v5 5/5] " Pradeep A. Dalvi
2012-02-06 21:16 ` [PATCH v6 " Pradeep A Dalvi
2012-02-08 23:50 ` David Miller
2012-02-06 16:45 ` [PATCH v5 1/5] " David Miller
2012-02-06 17:37 ` Pradeep A. Dalvi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120207.152905.1412072387367320828.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@pradeepdalvi.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).