From: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>,
netdev@vger.kernel.org
Subject: Re: [PATCH] skbuff: Add new tc classify variable
Date: Tue, 7 Feb 2012 20:57:29 +0100 [thread overview]
Message-ID: <20120207195729.GA26533@pandem0nium> (raw)
In-Reply-To: <20120207110522.70663963@nehalam.linuxnetplumber.net>
[-- Attachment #1: Type: text/plain, Size: 721 bytes --]
On Tue, Feb 07, 2012 at 11:05:22AM -0800, Stephen Hemminger wrote:
> On Tue, 7 Feb 2012 19:39:08 +0100
> Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de> wrote:
>
> I don't understand why this is better, we already have mark to do this.
> Your method saves adding a tc filter to map mark to classid, but that is hardly
> a huge burden.
Unfortunately, it is. We have previously built our trees by setting marks with iptables
and matching the masks with tc and the u32 matcher, but we got a rather big performance
impact as soon as the number of users grow. The target platform are WiFi access points.
By using the proposed patch, the performance stays nearly constant at a growing number
of users.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-02-07 19:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 18:39 [PATCH] skbuff: Add new tc classify variable Simon Wunderlich
2012-02-07 18:58 ` David Miller
2012-02-07 20:16 ` Simon Wunderlich
2012-02-07 20:33 ` Dave Taht
2012-02-08 9:21 ` Eric Dumazet
2012-02-08 14:48 ` jamal
2012-02-07 19:05 ` Stephen Hemminger
2012-02-07 19:57 ` Simon Wunderlich [this message]
2012-02-07 21:45 ` Stephen Hemminger
2012-02-08 8:54 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120207195729.GA26533@pandem0nium \
--to=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).