From: Stephen Hemminger <shemminger@vyatta.com>
To: Jeffrin Jose <ahiliation@yahoo.co.in>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1]net:ethernet:fixed a coding style issue relating space.
Date: Fri, 18 May 2012 14:56:17 -0700 [thread overview]
Message-ID: <20120518145617.710bc1d6@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1337377537-4636-1-git-send-email-ahiliation@yahoo.co.in>
On Sat, 19 May 2012 03:15:37 +0530
Jeffrin Jose <ahiliation@yahoo.co.in> wrote:
> Fixed a coding style issue relating to space found
> by checkpatch.pl tool in net/ethernet/eth.c
>
> Signed-off-by: Jeffrin Jose <ahiliation@yahoo.co.in>
> ---
> net/ethernet/eth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
> index 36e5880..c847aa6 100644
> --- a/net/ethernet/eth.c
> +++ b/net/ethernet/eth.c
> @@ -178,7 +178,7 @@ __be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev)
> * seems to set IFF_PROMISC.
> */
>
> - else if (1 /*dev->flags&IFF_PROMISC */ ) {
> + else if (1 /*dev->flags&IFF_PROMISC */) {
> if (unlikely(!ether_addr_equal_64bits(eth->h_dest,
> dev->dev_addr)))
> skb->pkt_type = PACKET_OTHERHOST;
Rather than put lips on a pig, why not remove the bogus if?
next prev parent reply other threads:[~2012-05-18 21:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 21:45 [PATCH 1/1]net:ethernet:fixed a coding style issue relating space Jeffrin Jose
2012-05-18 21:56 ` Stephen Hemminger [this message]
[not found] ` <1337421732.6524.YahooMailNeo@web192306.mail.sg3.yahoo.com>
2012-05-19 18:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120518145617.710bc1d6@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=ahiliation@yahoo.co.in \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).