From: "Chas Williams (CONTRACTOR)" <chas@cmf.nrl.navy.mil>
To: Krzysztof Mazur <krzysiek@podlesie.net>
Cc: David Woodhouse <dwmw2@infradead.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net
Subject: Re: [PATCH v3 8/7] pppoatm: fix missing wakeup in pppoatm_send()
Date: Sun, 11 Nov 2012 17:47:32 -0500 [thread overview]
Message-ID: <201211112247.qABMlWiQ021630@thirdoffive.cmf.nrl.navy.mil> (raw)
In-Reply-To: <20121111110437.GA25894@shrek.podlesie.net>
In message <20121111110437.GA25894@shrek.podlesie.net>,Krzysztof Mazur writes:
>Any race with testing vcc flags is probably not really important
>because:
> - vcc_release_async() does not take any lock so this check
> will be always racy so we are probably allowed to send
> new frames until vcc is really closed,
this locking/synchronization is handled in the atm device drivers.
the send and close routines are responsbile for synchronization (yes, i
believe that leads to duplicated code but that is the way it currently is)
prev parent reply other threads:[~2012-11-11 22:47 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 22:16 [PATCH v3 0/7] pppoatm: fix multiple issues with pppoatm driver Krzysztof Mazur
2012-11-06 22:16 ` [PATCH v3 1/7] atm: detach protocol before closing vcc Krzysztof Mazur
2012-11-06 22:16 ` [PATCH v3 2/7] atm: add owner of push() callback to atmvcc Krzysztof Mazur
2012-11-07 19:05 ` chas williams - CONTRACTOR
2012-11-06 22:16 ` [PATCH v3 3/7] pppoatm: allow assign only on a connected socket Krzysztof Mazur
2012-11-06 22:16 ` [PATCH v3 4/7] pppoatm: fix module_put() race Krzysztof Mazur
2012-11-06 22:17 ` [PATCH v3 5/7] pppoatm: take ATM socket lock in pppoatm_send() Krzysztof Mazur
2012-11-06 22:57 ` Woodhouse, David
2012-11-06 22:17 ` [PATCH v3 6/7] pppoatm: don't send frames on not-ready vcc Krzysztof Mazur
2012-11-06 22:17 ` [PATCH v3 7/7] pppoatm: do not inline pppoatm_may_send() Krzysztof Mazur
2012-11-07 12:52 ` [PATCH v3 8/7] pppoatm: fix missing wakeup in pppoatm_send() David Woodhouse
2012-11-09 21:30 ` David Miller
2012-11-10 7:36 ` David Woodhouse
2012-11-10 18:38 ` David Miller
2012-11-10 20:23 ` Krzysztof Mazur
2012-11-10 21:02 ` David Woodhouse
2012-11-10 22:33 ` Krzysztof Mazur
2012-11-11 7:28 ` David Woodhouse
2012-11-11 11:04 ` Krzysztof Mazur
2012-11-11 11:39 ` David Woodhouse
2012-11-11 13:50 ` Krzysztof Mazur
2012-11-11 15:26 ` David Woodhouse
2012-11-11 16:12 ` Krzysztof Mazur
2012-11-11 17:03 ` David Woodhouse
2012-11-11 18:49 ` Krzysztof Mazur
2012-11-11 20:51 ` David Woodhouse
2012-11-11 22:57 ` Chas Williams (CONTRACTOR)
2012-11-27 13:27 ` David Woodhouse
2012-11-27 15:23 ` chas williams - CONTRACTOR
2012-11-28 0:48 ` David Woodhouse
2012-11-28 8:12 ` Krzysztof Mazur
2012-11-28 9:24 ` David Woodhouse
2012-11-28 9:58 ` Krzysztof Mazur
2012-11-28 10:19 ` David Woodhouse
2012-11-11 22:47 ` Chas Williams (CONTRACTOR) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211112247.qABMlWiQ021630@thirdoffive.cmf.nrl.navy.mil \
--to=chas@cmf.nrl.navy.mil \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=krzysiek@podlesie.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).