netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: amwang@redhat.com
Cc: netdev@vger.kernel.org, dlstevens@us.ibm.com, stephen@networkplumber.org
Subject: Re: [Patch net-next v6 4/5] vxlan: add ipv6 support
Date: Mon, 29 Apr 2013 11:52:14 -0400 (EDT)	[thread overview]
Message-ID: <20130429.115214.930181179286504457.davem@davemloft.net> (raw)
In-Reply-To: <1366782874-18700-5-git-send-email-amwang@redhat.com>

From: Cong Wang <amwang@redhat.com>
Date: Wed, 24 Apr 2013 13:54:33 +0800

> +	rc = sock_create_kern(AF_INET6, SOCK_DGRAM, IPPROTO_UDP, &vn->sock);
> +	if (rc < 0) {
> +		pr_debug("UDP socket create failed\n");
> +		return rc;
> +	}

You have to fall back to creating and using an ipv4 socket if making
the ipv6 one fails.

IPV6 being enabled does not mean it is guaranteed the one can
successfully create ipv6 sockets.

You also must handle /proc/sys/net/ipv6/conf/${DEV}/disable_ipv6
correctly as far as this stuff goes as well.

  reply	other threads:[~2013-04-29 15:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-24  5:54 [Patch net-next v6 0/5] vxlan: add ipv6 support Cong Wang
2013-04-24  5:54 ` [Patch net-next v6 1/5] vxlan: defer vxlan init as late as possible Cong Wang
2013-04-24  5:54 ` [Patch net-next v6 2/5] ipv6: export a stub for ipv6_sock_mc_join and ipv6_sock_mc_drop Cong Wang
2013-04-24  5:54 ` [Patch net-next v6 3/5] ipv6: export in6addr_loopback to modules Cong Wang
2013-04-24  5:54 ` [Patch net-next v6 4/5] vxlan: add ipv6 support Cong Wang
2013-04-29 15:52   ` David Miller [this message]
2013-04-30  3:59     ` Cong Wang
2013-04-24  5:54 ` [Patch net-next v6 5/5] ipv6: Add generic UDP Tunnel segmentation Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130429.115214.930181179286504457.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=amwang@redhat.com \
    --cc=dlstevens@us.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).