* [PATCH] net_sched: act_ipt forward compat with xtables
@ 2013-04-28 15:06 Jamal Hadi Salim
2013-05-01 17:20 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jamal Hadi Salim @ 2013-04-28 15:06 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Hasan Chowdhury, Jan Engelhardt
[-- Attachment #1: Type: text/plain, Size: 445 bytes --]
I have done minimal testing on this on my environment. I took Jan's
advise to simplify things.
Hasan,
I know you have your head buried in the sand right now; but please
when you get the time test this patch with the latest iproute2 git
tree and send your tested-by credential.
Dave,
When Hasan nods I think this should also go into stable because none
of the newer kernels work with newer iptables (which is a lot of
distros).
cheers,
jamal
[-- Attachment #2: patch-xt-alter2 --]
[-- Type: text/plain, Size: 1849 bytes --]
commit 94c39d99038dd7fdea4922ae4cfb4ad683c1307c
Author: Jamal Hadi Salim <jhs@mojatatu.com>
Date: Sun Apr 28 10:46:56 2013 -0400
Deal with changes in newer xtables while maintaining backward
compatibility. Thanks to Jan Engelhardt for suggestions.
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
diff --git a/net/sched/act_ipt.c b/net/sched/act_ipt.c
index e0f6de6..60d88b6 100644
--- a/net/sched/act_ipt.c
+++ b/net/sched/act_ipt.c
@@ -8,7 +8,7 @@
* as published by the Free Software Foundation; either version
* 2 of the License, or (at your option) any later version.
*
- * Copyright: Jamal Hadi Salim (2002-4)
+ * Copyright: Jamal Hadi Salim (2002-13)
*/
#include <linux/types.h>
@@ -303,17 +303,44 @@ static struct tc_action_ops act_ipt_ops = {
.walk = tcf_generic_walker
};
-MODULE_AUTHOR("Jamal Hadi Salim(2002-4)");
+static struct tc_action_ops act_xt_ops = {
+ .kind = "xt",
+ .hinfo = &ipt_hash_info,
+ .type = TCA_ACT_IPT,
+ .capab = TCA_CAP_NONE,
+ .owner = THIS_MODULE,
+ .act = tcf_ipt,
+ .dump = tcf_ipt_dump,
+ .cleanup = tcf_ipt_cleanup,
+ .lookup = tcf_hash_search,
+ .init = tcf_ipt_init,
+ .walk = tcf_generic_walker
+};
+
+MODULE_AUTHOR("Jamal Hadi Salim(2002-13)");
MODULE_DESCRIPTION("Iptables target actions");
MODULE_LICENSE("GPL");
+MODULE_ALIAS("act_xt");
static int __init ipt_init_module(void)
{
- return tcf_register_action(&act_ipt_ops);
+ int ret1, ret2;
+ ret1 = tcf_register_action(&act_xt_ops);
+ if (ret1 < 0)
+ printk("Failed to load xt action\n");
+ ret2 = tcf_register_action(&act_ipt_ops);
+ if (ret2 < 0)
+ printk("Failed to load ipt action\n");
+
+ if (ret1 < 0 && ret2 < 0)
+ return ret1;
+ else
+ return 0;
}
static void __exit ipt_cleanup_module(void)
{
+ tcf_unregister_action(&act_xt_ops);
tcf_unregister_action(&act_ipt_ops);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net_sched: act_ipt forward compat with xtables
2013-04-28 15:06 [PATCH] net_sched: act_ipt forward compat with xtables Jamal Hadi Salim
@ 2013-05-01 17:20 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-05-01 17:20 UTC (permalink / raw)
To: jhs; +Cc: netdev, shemonc, jengelh
From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: Sun, 28 Apr 2013 11:06:38 -0400
> When Hasan nods I think this should also go into stable because none
> of the newer kernels work with newer iptables (which is a lot of
> distros).
I'm tired waiting, applied and queued up for -stable, thanks Jamal.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-01 17:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-28 15:06 [PATCH] net_sched: act_ipt forward compat with xtables Jamal Hadi Salim
2013-05-01 17:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).