netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] netlink: Fix skb ref counting.
@ 2013-04-30  6:52 Pravin B Shelar
  2013-04-30 19:47 ` David Miller
  2013-05-01 18:58 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Pravin B Shelar @ 2013-04-30  6:52 UTC (permalink / raw)
  To: netdev; +Cc: Pravin B Shelar, Patrick McHardy

Commit f9c2288837ba072b21dba955f04a4c97eaa77b1e (netlink:
implement memory mapped recvmsg) increamented skb->users
ref count twice for a dump op which does not look right.

Following patch fixes that.

CC: Patrick McHardy <kaber@trash.net>
Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
---
 net/netlink/af_netlink.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index d9c7869..12ac6b4 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -2504,7 +2504,6 @@ int __netlink_dump_start(struct sock *ssk, struct sk_buff *skb,
 	cb->data = control->data;
 	cb->module = control->module;
 	cb->min_dump_alloc = control->min_dump_alloc;
-	atomic_inc(&skb->users);
 	cb->skb = skb;
 
 	sk = netlink_lookup(sock_net(ssk), ssk->sk_protocol, NETLINK_CB(skb).portid);
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] netlink: Fix skb ref counting.
  2013-04-30  6:52 [PATCH net-next] netlink: Fix skb ref counting Pravin B Shelar
@ 2013-04-30 19:47 ` David Miller
  2013-05-01 18:58 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-04-30 19:47 UTC (permalink / raw)
  To: pshelar; +Cc: netdev, kaber

From: Pravin B Shelar <pshelar@nicira.com>
Date: Mon, 29 Apr 2013 23:52:01 -0700

> Commit f9c2288837ba072b21dba955f04a4c97eaa77b1e (netlink:
> implement memory mapped recvmsg) increamented skb->users
> ref count twice for a dump op which does not look right.
> 
> Following patch fixes that.
> 
> CC: Patrick McHardy <kaber@trash.net>
> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>

Patrick, please review this, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] netlink: Fix skb ref counting.
  2013-04-30  6:52 [PATCH net-next] netlink: Fix skb ref counting Pravin B Shelar
  2013-04-30 19:47 ` David Miller
@ 2013-05-01 18:58 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-05-01 18:58 UTC (permalink / raw)
  To: pshelar; +Cc: netdev, kaber

From: Pravin B Shelar <pshelar@nicira.com>
Date: Mon, 29 Apr 2013 23:52:01 -0700

> Commit f9c2288837ba072b21dba955f04a4c97eaa77b1e (netlink:
> implement memory mapped recvmsg) increamented skb->users
> ref count twice for a dump op which does not look right.
> 
> Following patch fixes that.
> 
> CC: Patrick McHardy <kaber@trash.net>
> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>

I'm tired of waiting for Patrick to review this, to me a lack of a
timely review translated into "it's not important to me" so...

Applied, thanks Pravin.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-05-01 18:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-30  6:52 [PATCH net-next] netlink: Fix skb ref counting Pravin B Shelar
2013-04-30 19:47 ` David Miller
2013-05-01 18:58 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).