From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: netdev@vger.kernel.org, bvanassche@acm.org
Subject: Re: [PATCH RFC] netpoll: convert mutex into a semaphore
Date: Wed, 01 May 2013 15:00:59 -0400 (EDT) [thread overview]
Message-ID: <20130501.150059.785741895635621733.davem@davemloft.net> (raw)
In-Reply-To: <1367336105-6275-1-git-send-email-nhorman@tuxdriver.com>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Tue, 30 Apr 2013 11:35:05 -0400
> Bart Van Assche recently reported a warning to me:
...
> This resulted from my commit ca99ca14c which introduced a mutex_trylock
> operation in a path that could execute in interrupt context. When mutex
> debugging is enabled, the above warns the user when we are in fact
> exectuting in interrupt context
> interrupt context.
>
> After some discussion, It seems that a semaphore is the proper mechanism to use
> here. While mutexes are defined to be unusable in interrupt context, no such
> condition exists for semaphores (save for the fact that the non blocking api
> calls, like up and down_trylock must be used when in irq context).
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> Reported-by: Bart Van Assche <bvanassche@acm.org>
Neil this looks good to me so I'm going to toss it into my tree and queue
it up for -stable too, thanks!
next prev parent reply other threads:[~2013-05-01 19:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 13:42 Netpoll triggers soft lockup Bart Van Assche
2013-04-11 14:08 ` Neil Horman
2013-04-11 15:18 ` [PATCH RFC] spinlock: split out debugging check from spin_lock_mutex Neil Horman
2013-04-11 15:54 ` Christoph Paasch
2013-04-11 17:04 ` Neil Horman
2013-04-11 17:51 ` Christoph Paasch
2013-04-11 15:57 ` Eric Dumazet
2013-04-11 16:56 ` Neil Horman
2013-04-11 17:31 ` Bart Van Assche
2013-04-11 17:52 ` Neil Horman
2013-04-11 19:14 ` Neil Horman
2013-04-12 6:27 ` Bart Van Assche
2013-04-12 11:32 ` Neil Horman
2013-04-12 14:01 ` Bart Van Assche
2013-04-12 18:45 ` Neil Horman
2013-04-13 7:35 ` Bart Van Assche
2013-04-13 12:03 ` Neil Horman
2013-04-15 14:16 ` Neil Horman
[not found] ` <CAO+b5-oBfH3M0dnrQSs-p1BF_5hKy2tsU-dD=EP9+S=iqPs5ew@mail.gmail.com>
2013-04-16 17:24 ` Neil Horman
2013-04-18 19:29 ` Neil Horman
2013-04-22 20:12 ` Neil Horman
[not found] ` <CAO+b5-r5jVJNZWuREUH5MQ3baeSPR8fVV1p9pMnukmiZd9nRhg@mail.gmail.com>
2013-04-23 13:23 ` Neil Horman
[not found] ` <CAO+b5-rQPyO9QE9v+oQTeo+G-ftcsehSB5=63AZ13QW4EJ1X0Q@mail.gmail.com>
2013-04-23 13:44 ` Neil Horman
2013-04-23 17:33 ` David Miller
2013-04-23 17:50 ` Neil Horman
2013-04-27 18:53 ` bvba Bart Van Assche
2013-04-29 18:13 ` Neil Horman
2013-04-29 19:12 ` Bart Van Assche
2013-04-30 15:35 ` [PATCH RFC] netpoll: convert mutex into a semaphore Neil Horman
2013-05-01 19:00 ` David Miller [this message]
2013-05-01 19:34 ` Neil Horman
2013-04-19 8:38 ` [PATCH RFC] spinlock: split out debugging check from spin_lock_mutex Ingo Molnar
2013-04-19 12:52 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130501.150059.785741895635621733.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bvanassche@acm.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).