netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Timo Teras <timo.teras@iki.fi>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [regression] [analyzed] fragmentation broken for tunnel devices
Date: Wed, 1 May 2013 09:46:45 +0300	[thread overview]
Message-ID: <20130501094645.715bb462@vostro> (raw)
In-Reply-To: <20130320.134640.1857052324535652751.davem@davemloft.net>

On Wed, 20 Mar 2013 13:46:40 -0400 (EDT)
David Miller <davem@davemloft.net> wrote:

> From: Timo Teras <timo.teras@iki.fi>
> Date: Wed, 20 Mar 2013 10:13:18 +0200
> 
> Thanks for investigating this issue.
> 
> > 3) Reimplement fragmentation in tunnel devices. This means some
> > duplication of code. But now that there's GRO support in tunnels,
> > this would seem the most performant option.
> 
> I think this is the best option, especially in the long term.

I've been thinking more. It seems there's going to be tricky cases with
this approach too. Looks like ICMP and other non-TCP/UDP packets are
not really sent as GSO/GRO packets. So for those we end up fragmenting
multiple times and end up sending double the amount of packets than
needed.

This would also mean that if we are ever to support new protocols, e.g.
MPLS, we'd get a whole new can of forms when needing fragmentation.

I'm wondering now if it'd be easier to just do the additional
nexthop consultation for forward routes where destination is a tunnel
device.

- Timo

      reply	other threads:[~2013-05-01  6:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-13 15:14 linux-3.6+, gre+ipsec+forwarding = IP fragmentation broken Timo Teras
2013-03-15  9:25 ` Timo Teras
2013-03-15 11:38   ` Timo Teras
2013-03-15 13:03     ` Timo Teras
     [not found]       ` <20130320101318.4196d93a@vostro>
2013-03-20 17:46         ` [regression] [analyzed] fragmentation broken for tunnel devices David Miller
2013-05-01  6:46           ` Timo Teras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130501094645.715bb462@vostro \
    --to=timo.teras@iki.fi \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).