From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [GIT] Networking Date: Thu, 02 May 2013 13:39:47 -0400 (EDT) Message-ID: <20130502.133947.387694205526879673.davem@davemloft.net> References: <20130501.164755.1859264969403837546.davem@davemloft.net> <1367512467.4000.7.camel@dcbw.foobar.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: torvalds@linux-foundation.org, hayeswang@realtek.com, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: dcbw@redhat.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:58528 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757049Ab3EBRju (ORCPT ); Thu, 2 May 2013 13:39:50 -0400 In-Reply-To: <1367512467.4000.7.camel@dcbw.foobar.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Dan Williams Date: Thu, 02 May 2013 11:34:27 -0500 > On Wed, 2013-05-01 at 18:28 -0700, Linus Torvalds wrote: >> On Wed, May 1, 2013 at 1:47 PM, David Miller wrote: >> > >> > Highlights (1721 non-merge commits, this has to be a record of some >> > sort): >> >> Lowlight: it completely breaks my machine with r8169 ethernet. In the >> networkmanager applet, it claims no cable connection, which is a bit >> odd, because (a) it works with an older kernel and (b) the kernel >> messages actually say >> >> r8169 0000:01:00.0 eth0: link up > > NM calls ETHTOOL_GLINK and if that returns success, NM expects the > driver to support carrier detection. NM then listens to netlink for > device flags changes, and uses IFF_LOWER_UP to determine carrier on/off > state. NM does not use NETIF_F_VLAN_CHALLENGED or any of the other > ETHTOOL_GFEATURES flags yet, but will in the future. > > Is the link status accurately reflected by /sys/class/net/eth0/carrier ? Something cares about the .../eth0/flags value because with the bit ordering different for bits 10 and above things break.