From: David Miller <davem@davemloft.net>
To: Frank.Li@freescale.com
Cc: romieu@fr.zoreil.com, r.schwebel@pengutronix.de,
l.stach@pengutronix.de, netdev@vger.kernel.org,
festevam@gmail.com, shawn.guo@linaro.org, lznuaa@gmail.com
Subject: Re: [PATCH v3 1/1 net] net: fec: fix kernel oops when plug/unplug cable many times
Date: Thu, 02 May 2013 16:48:53 -0400 (EDT) [thread overview]
Message-ID: <20130502.164853.1057531869767418902.davem@davemloft.net> (raw)
In-Reply-To: <1367456138-27172-1-git-send-email-Frank.Li@freescale.com>
From: Frank Li <Frank.Li@freescale.com>
Date: Thu, 2 May 2013 08:55:38 +0800
> reproduce steps
> 1. flood ping from other machine
> ping -f -s 41000 IP
> 2. run below script
> while [ 1 ]; do ethtool -s eth0 autoneg off;
> sleep 3;ethtool -s eth0 autoneg on; sleep 4; done;
>
> You can see oops in one hour.
>
> The reason is fec_restart clear BD but NAPI may use it.
> The solution is disable NAPI and stop xmit when reset BD.
> disable NAPI may sleep, so fec_restart can't be call in
> atomic context.
>
> Signed-off-by: Frank Li <Frank.Li@freescale.com>
Please respin this against the current 'net' tree.
Thanks!
next prev parent reply other threads:[~2013-05-02 20:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 0:55 [PATCH v3 1/1 net] net: fec: fix kernel oops when plug/unplug cable many times Frank Li
2013-05-02 20:48 ` David Miller [this message]
2013-05-06 7:47 ` Frank Li
2013-05-06 9:19 ` Lucas Stach
2013-05-06 9:56 ` Frank Li
2013-05-06 10:16 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130502.164853.1057531869767418902.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Frank.Li@freescale.com \
--cc=festevam@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=lznuaa@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=r.schwebel@pengutronix.de \
--cc=romieu@fr.zoreil.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).