From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH v3 03/16] lockdep: remove task argument from debug_check_no_locks_held Date: Tue, 7 May 2013 14:28:23 +0200 Message-ID: <20130507122823.GB2585@elf.ucw.cz> References: <1367884221-20462-1-git-send-email-ccross@android.com> <1367884221-20462-4-git-send-email-ccross@android.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Peter Zijlstra , Ingo Molnar , Andrew Morton , Mandeep Singh Baines , Oleg Nesterov , linux-nfs@vger.kernel.org, linux-pm@vger.kernel.org, netdev@vger.kernel.org, Linus Torvalds , Tejun Heo , Paul Walmsley , Al Viro , "Eric W. Biederman" , David Howells To: Colin Cross Return-path: Content-Disposition: inline In-Reply-To: <1367884221-20462-4-git-send-email-ccross@android.com> Sender: linux-pm-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon 2013-05-06 16:50:08, Colin Cross wrote: > The only existing caller to debug_check_no_locks_held calls it > with 'current' as the task, and the freezer needs to call > debug_check_no_locks_held but doesn't already have a current > task pointer, so remove the argument. It is already assuming > that the current task is relevant by dumping the current stack > trace as part of the warning. > > This was originally part of 6aa9707099c (lockdep: check that > no locks held at freeze time) which was reverted in > dbf520a9d7d4. > > Original-author: Mandeep Singh Baines > Signed-off-by: Colin Cross Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html