Fw: [Bug 57851] New: a mistake about macro definition of FIB_TABLE_HASHSZ

Fw: [Bug 57851] New: a mistake about macro definition of FIB_TABLE_HASHSZ

[Stephen Hemminger]

Don't know if this already made it to netdev. Google SMTP had been
flaky and didn't take it yesterday.


Subject: [Bug 57851] New: a mistake about macro definition of FIB_TABLE_HASHSZ


https://bugzilla.kernel.org/show_bug.cgi?id=57851

           Summary: a mistake about macro definition of FIB_TABLE_HASHSZ
           Product: Networking
           Version: 2.5
    Kernel Version: 3.5
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Other
        AssignedTo: shemminger@linux-foundation.org
        ReportedBy: nosongyang@gmail.com
        Regression: No


#ifdef CONFIG_IP_ROUTE_MULTIPATH

#define FIB_RES_NH(res)          ((res).fi->fib_nh[(res).nh_sel])

#define FIB_TABLE_HASHSZ 2

#else /* CONFIG_IP_ROUTE_MULTIPATH */

#define FIB_RES_NH(res)          ((res).fi->fib_nh[0])

#define FIB_TABLE_HASHSZ 256

#endif /* CONFIG_IP_ROUTE_MULTIPATH */

There is a confuse macro definition about the FIB_TABLE_HASHSZ. This mistake
can generate an error, but will affect performance.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Re: [Bug 57851] New: a mistake about macro definition of FIB_TABLE_HASHSZ

[David Miller]

This has been fixed for nearly 2 months:

commit 5b9e12dbf92b441b37136ea71dac59f05f2673a9
Author: Denis V. Lunev <den@openvz.org>
Date:   Wed Mar 13 00:24:15 2013 +0000

    ipv4: fix definition of FIB_TABLE_HASHSZ