* [PATCH 05/21] 9p: remove inline marking of EXPORT_SYMBOL functions
[not found] <1368086241-9357-1-git-send-email-yefremov.denis@gmail.com>
@ 2013-05-09 7:58 ` Denis Efremov
2013-05-09 9:19 ` [PATCH 07/21] netfilter: nf_nat: " Denis Efremov
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Denis Efremov @ 2013-05-09 7:58 UTC (permalink / raw)
To: David S. Miller
Cc: Denis Efremov, Eric W. Biederman, netdev, linux-kernel, trivial,
ldv-project
EXPORT_SYMBOL and inline directives are contradictory to each other.
The patch fixes this inconsistency.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
---
net/9p/client.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/9p/client.c b/net/9p/client.c
index 8eb7542..591c664 100644
--- a/net/9p/client.c
+++ b/net/9p/client.c
@@ -64,13 +64,13 @@ static const match_table_t tokens = {
{Opt_err, NULL},
};
-inline int p9_is_proto_dotl(struct p9_client *clnt)
+int p9_is_proto_dotl(struct p9_client *clnt)
{
return clnt->proto_version == p9_proto_2000L;
}
EXPORT_SYMBOL(p9_is_proto_dotl);
-inline int p9_is_proto_dotu(struct p9_client *clnt)
+int p9_is_proto_dotu(struct p9_client *clnt)
{
return clnt->proto_version == p9_proto_2000u;
}
--
1.8.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 07/21] netfilter: nf_nat: remove inline marking of EXPORT_SYMBOL functions
[not found] <1368086241-9357-1-git-send-email-yefremov.denis@gmail.com>
2013-05-09 7:58 ` [PATCH 05/21] 9p: remove inline marking of EXPORT_SYMBOL functions Denis Efremov
@ 2013-05-09 9:19 ` Denis Efremov
2013-05-09 9:47 ` David Laight
2013-05-09 9:19 ` [PATCH 08/21] iwlegacy: " Denis Efremov
2013-05-09 9:19 ` [PATCH 11/21] ipv4: ip_output: " Denis Efremov
3 siblings, 1 reply; 6+ messages in thread
From: Denis Efremov @ 2013-05-09 9:19 UTC (permalink / raw)
To: David S. Miller
Cc: Denis Efremov, Pablo Neira Ayuso, Patrick McHardy, netfilter,
netdev, linux-kernel, trivial, ldv-project
EXPORT_SYMBOL and inline directives are contradictory to each other.
The patch fixes this inconsistency.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
---
net/netfilter/nf_nat_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nf_nat_core.c b/net/netfilter/nf_nat_core.c
index 038eee5..38492e0 100644
--- a/net/netfilter/nf_nat_core.c
+++ b/net/netfilter/nf_nat_core.c
@@ -44,7 +44,7 @@ __nf_nat_l3proto_find(u8 family)
return rcu_dereference(nf_nat_l3protos[family]);
}
-inline const struct nf_nat_l4proto *
+const struct nf_nat_l4proto *
__nf_nat_l4proto_find(u8 family, u8 protonum)
{
return rcu_dereference(nf_nat_l4protos[family][protonum]);
--
1.8.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 08/21] iwlegacy: remove inline marking of EXPORT_SYMBOL functions
[not found] <1368086241-9357-1-git-send-email-yefremov.denis@gmail.com>
2013-05-09 7:58 ` [PATCH 05/21] 9p: remove inline marking of EXPORT_SYMBOL functions Denis Efremov
2013-05-09 9:19 ` [PATCH 07/21] netfilter: nf_nat: " Denis Efremov
@ 2013-05-09 9:19 ` Denis Efremov
2013-05-09 9:19 ` [PATCH 11/21] ipv4: ip_output: " Denis Efremov
3 siblings, 0 replies; 6+ messages in thread
From: Denis Efremov @ 2013-05-09 9:19 UTC (permalink / raw)
To: Stanislaw Gruszka
Cc: Denis Efremov, John W. Linville, linux-wireless, netdev,
linux-kernel, trivial, ldv-project
EXPORT_SYMBOL and inline directives are contradictory to each other.
The patch fixes this inconsistency.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
---
drivers/net/wireless/iwlegacy/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/iwlegacy/common.c b/drivers/net/wireless/iwlegacy/common.c
index 592d0aa..e9a3cbc 100644
--- a/drivers/net/wireless/iwlegacy/common.c
+++ b/drivers/net/wireless/iwlegacy/common.c
@@ -1423,7 +1423,7 @@ il_setup_rx_scan_handlers(struct il_priv *il)
}
EXPORT_SYMBOL(il_setup_rx_scan_handlers);
-inline u16
+u16
il_get_active_dwell_time(struct il_priv *il, enum ieee80211_band band,
u8 n_probes)
{
--
1.8.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 11/21] ipv4: ip_output: remove inline marking of EXPORT_SYMBOL functions
[not found] <1368086241-9357-1-git-send-email-yefremov.denis@gmail.com>
` (2 preceding siblings ...)
2013-05-09 9:19 ` [PATCH 08/21] iwlegacy: " Denis Efremov
@ 2013-05-09 9:19 ` Denis Efremov
2013-05-11 23:13 ` David Miller
3 siblings, 1 reply; 6+ messages in thread
From: Denis Efremov @ 2013-05-09 9:19 UTC (permalink / raw)
To: David S. Miller
Cc: Denis Efremov, Alexey Kuznetsov, James Morris, Hideaki YOSHIFUJI,
Patrick McHardy, netdev, linux-kernel, trivial, ldv-project
EXPORT_SYMBOL and inline directives are contradictory to each other.
The patch fixes this inconsistency.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
---
net/ipv4/ip_output.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
index 147abf5..4bcabf3 100644
--- a/net/ipv4/ip_output.c
+++ b/net/ipv4/ip_output.c
@@ -84,7 +84,7 @@ int sysctl_ip_default_ttl __read_mostly = IPDEFTTL;
EXPORT_SYMBOL(sysctl_ip_default_ttl);
/* Generate a checksum for an outgoing IP datagram. */
-__inline__ void ip_send_check(struct iphdr *iph)
+void ip_send_check(struct iphdr *iph)
{
iph->check = 0;
iph->check = ip_fast_csum((unsigned char *)iph, iph->ihl);
--
1.8.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH 07/21] netfilter: nf_nat: remove inline marking of EXPORT_SYMBOL functions
2013-05-09 9:19 ` [PATCH 07/21] netfilter: nf_nat: " Denis Efremov
@ 2013-05-09 9:47 ` David Laight
0 siblings, 0 replies; 6+ messages in thread
From: David Laight @ 2013-05-09 9:47 UTC (permalink / raw)
To: Denis Efremov, David S. Miller
Cc: Pablo Neira Ayuso, Patrick McHardy, netfilter, netdev,
linux-kernel, trivial, ldv-project
> EXPORT_SYMBOL and inline directives are contradictory to each other.
> The patch fixes this inconsistency.
...
> -inline const struct nf_nat_l4proto *
> +const struct nf_nat_l4proto *
> __nf_nat_l4proto_find(u8 family, u8 protonum)
> {
> return rcu_dereference(nf_nat_l4protos[family][protonum]);
If it makes sense to inline the local calls (ie the cost
of the call is significant) then possibly add an inlined
(or inlinable) static function that is called locally and
by the exported one?
I'm not sure that gcc is allowed to make the assumption
that the local exported function will be called - and
thus inline it.
David
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 11/21] ipv4: ip_output: remove inline marking of EXPORT_SYMBOL functions
2013-05-09 9:19 ` [PATCH 11/21] ipv4: ip_output: " Denis Efremov
@ 2013-05-11 23:13 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2013-05-11 23:13 UTC (permalink / raw)
To: yefremov.denis
Cc: kuznet, jmorris, yoshfuji, kaber, netdev, linux-kernel, trivial,
ldv-project
From: Denis Efremov <yefremov.denis@gmail.com>
Date: Thu, 9 May 2013 13:19:42 +0400
> EXPORT_SYMBOL and inline directives are contradictory to each other.
> The patch fixes this inconsistency.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-05-11 23:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1368086241-9357-1-git-send-email-yefremov.denis@gmail.com>
2013-05-09 7:58 ` [PATCH 05/21] 9p: remove inline marking of EXPORT_SYMBOL functions Denis Efremov
2013-05-09 9:19 ` [PATCH 07/21] netfilter: nf_nat: " Denis Efremov
2013-05-09 9:47 ` David Laight
2013-05-09 9:19 ` [PATCH 08/21] iwlegacy: " Denis Efremov
2013-05-09 9:19 ` [PATCH 11/21] ipv4: ip_output: " Denis Efremov
2013-05-11 23:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).