* [Patch net] virtio_net: use default napi weight by default
@ 2013-05-10 5:50 Cong Wang
2013-05-12 0:41 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Cong Wang @ 2013-05-10 5:50 UTC (permalink / raw)
To: netdev; +Cc: Michael S. Tsirkin, Eric Dumazet, David S. Miller, Cong Wang
Since commit 82dc3c63c692b1e1d5937(net: introduce NAPI_POLL_WEIGHT)
we warn drivers when they use napi weight higher than NAPI_POLL_WEIGHT,
but virtio_net still uses 128 by default. This patch makes its default
value to NAPI_POLL_WEIGHT.
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Cong Wang <amwang@redhat.com>
---
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 3c23fdc..655bb25 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -28,7 +28,7 @@
#include <linux/slab.h>
#include <linux/cpu.h>
-static int napi_weight = 128;
+static int napi_weight = NAPI_POLL_WEIGHT;
module_param(napi_weight, int, 0444);
static bool csum = true, gso = true;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch net] virtio_net: use default napi weight by default
2013-05-10 5:50 [Patch net] virtio_net: use default napi weight by default Cong Wang
@ 2013-05-12 0:41 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-05-12 0:41 UTC (permalink / raw)
To: amwang; +Cc: netdev, mst, eric.dumazet
From: Cong Wang <amwang@redhat.com>
Date: Fri, 10 May 2013 13:50:51 +0800
> Since commit 82dc3c63c692b1e1d5937(net: introduce NAPI_POLL_WEIGHT)
I corrected this to:
commit 82dc3c63c692b1e1d5937 ("net: introduce NAPI_POLL_WEIGHT")
> we warn drivers when they use napi weight higher than NAPI_POLL_WEIGHT,
> but virtio_net still uses 128 by default. This patch makes its default
> value to NAPI_POLL_WEIGHT.
>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Eric Dumazet <eric.dumazet@gmail.com>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Cong Wang <amwang@redhat.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-12 0:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-10 5:50 [Patch net] virtio_net: use default napi weight by default Cong Wang
2013-05-12 0:41 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).