From: Stephen Hemminger <stephen@networkplumber.org>
To: "David S. Miller" <davem@davemloft.net>,
David Woodhouse <David.Woodhouse@intel.com>,
Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev@vger.kernel.org
Subject: [PATCH net] 8139cp: reset BQL when ring tx ring cleared
Date: Sat, 11 May 2013 17:09:23 -0700 [thread overview]
Message-ID: <20130511170923.52673453@nehalam.linuxnetplumber.net> (raw)
While looking for other problem found this potential issue.
When the transmit ring is cleaned out, the Byte Queue Limit values
need to be reset.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
--- a/drivers/net/ethernet/realtek/8139cp.c 2013-05-02 14:30:52.182573290 -0700
+++ b/drivers/net/ethernet/realtek/8139cp.c 2013-05-11 17:06:51.163362372 -0700
@@ -1136,6 +1136,7 @@ static void cp_clean_rings (struct cp_pr
cp->dev->stats.tx_dropped++;
}
}
+ netdev_tx_reset_queue(cp->dev);
memset(cp->rx_ring, 0, sizeof(struct cp_desc) * CP_RX_RING_SIZE);
memset(cp->tx_ring, 0, sizeof(struct cp_desc) * CP_TX_RING_SIZE);
next reply other threads:[~2013-05-12 0:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-12 0:09 Stephen Hemminger [this message]
2013-05-12 1:21 ` [PATCH net] 8139cp: reset BQL when ring tx ring cleared David Miller
2013-05-12 2:30 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130511170923.52673453@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=David.Woodhouse@intel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).