From: Simon Horman <horms@verge.net.au>
To: Jesse Gross <jesse@nicira.com>
Cc: "dev@openvswitch.org" <dev@openvswitch.org>,
netdev <netdev@vger.kernel.org>, Ravi K <rkerur@gmail.com>,
Isaku Yamahata <yamahata@valinux.co.jp>,
Pravin B Shelar <pshelar@nicira.com>,
Jarno Rajahalme <jarno.rajahalme@nsn.com>,
Joe Stringer <joe@wand.net.nz>
Subject: Re: [PATCH v2.34] datapath: Add basic MPLS support to kernel
Date: Tue, 2 Jul 2013 13:16:28 +0900 [thread overview]
Message-ID: <20130702041628.GD14567@verge.net.au> (raw)
In-Reply-To: <CAEP_g=-uMQuwK7=35XG8xrToFDoe8HS8yBK51tSWOipS0FdYtA@mail.gmail.com>
On Mon, Jul 01, 2013 at 04:42:46PM -0700, Jesse Gross wrote:
> On Wed, Jun 26, 2013 at 1:18 AM, Simon Horman <horms@verge.net.au> wrote:
> > Allow datapath to recognize and extract MPLS labels into flow keys
> > and execute actions which push, pop, and set labels on packets.
> >
> > Based heavily on work by Leo Alterman, Ravi K, Isaku Yamahata and Joe Stringer.
> >
> > Cc: Ravi K <rkerur@gmail.com>
> > Cc: Leo Alterman <lalterman@nicira.com>
> > Cc: Isaku Yamahata <yamahata@valinux.co.jp>
> > Cc: Joe Stringer <joe@wand.net.nz>
> > Signed-off-by: Simon Horman <horms@verge.net.au>
>
> Simon, have you thought any more about the header ordering issues? I
> don't think we've reached a conclusion at this point.
I believe that you then raised the issue of QinQ, which somehow
I failed to respond to, I apologise for that.
In particular, my understanding is that you are concerned the code will
miss-calculate the end of L2 headers in the presence of multiple VLAN tags.
Thus resulting in an MPLS push action inserting an MPLS LSE after the first
rather than the last VLAN tag. And that would likely change if QinQ support
was added to Open vSwtich.
I wonder if a good way forwards is to enhance the calculation
of the end of L2 headers (mac_len) and the beginning of L3 headers
(network_header) in ovs_flow_extract() such that it takes into
account the presence of more than one VLAN tag.
next prev parent reply other threads:[~2013-07-02 4:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 8:18 [PATCH v2.34] datapath: Add basic MPLS support to kernel Simon Horman
2013-07-01 23:42 ` Jesse Gross
2013-07-02 4:16 ` Simon Horman [this message]
2013-07-02 21:59 ` Jesse Gross
2013-07-03 1:31 ` Simon Horman
2013-07-09 6:51 ` Jesse Gross
2013-07-11 0:16 ` Simon Horman
[not found] ` <20130711001655.GA22153-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2013-07-12 1:26 ` Jesse Gross
2013-07-12 1:55 ` Simon Horman
[not found] ` <20130712015538.GA30897-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2013-07-12 16:22 ` Jesse Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130702041628.GD14567@verge.net.au \
--to=horms@verge.net.au \
--cc=dev@openvswitch.org \
--cc=jarno.rajahalme@nsn.com \
--cc=jesse@nicira.com \
--cc=joe@wand.net.nz \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=rkerur@gmail.com \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).