netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: annie li <annie.li@oracle.com>
Cc: Wei Liu <wei.liu2@citrix.com>, <xen-devel@lists.xensource.com>,
	<netdev@vger.kernel.org>, <Ian.Campbell@citrix.com>,
	<konrad.wilk@oracle.com>
Subject: Re: [PATCH 1/1] xen/netback: correctly calculate required slots of skb.
Date: Wed, 10 Jul 2013 08:48:51 +0100	[thread overview]
Message-ID: <20130710074851.GH19798@zion.uk.xensource.com> (raw)
In-Reply-To: <51DCC795.2070806@oracle.com>

On Wed, Jul 10, 2013 at 10:31:49AM +0800, annie li wrote:
[...]
> >This seems to differ from netbk_gop_frag_copy. In that function it's
> >like
> >
> >     if (*head && skb_shinfo(skb)->gso_size && !vif->gso_prefix)
> 
> I mixed netbk_gop_frag_copy and xen_netbk_count_skb_slots just now,
> so please ignore the comments here in my last email.
> In xen_netbk_count_skb_slots, we have following code already, so it
> is not necessary to add gso condition here.
> 
>         if (skb_shinfo(skb)->gso_size)
>                 count++;
> 

Oh I see. But the condition still seems to be different from the
original one -- you missed !vif->gso_prefix.


Wei.

  reply	other threads:[~2013-07-10  7:48 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-09  6:15 [PATCH 1/1] xen/netback: correctly calculate required slots of skb Annie Li
2013-07-09 16:16 ` Wei Liu
2013-07-10  1:57   ` annie li
2013-07-10  2:31   ` annie li
2013-07-10  7:48     ` Wei Liu [this message]
2013-07-10  8:34       ` annie li
2013-07-09 22:14 ` Matt Wilson
2013-07-09 22:40   ` [PATCH RFC] xen-netback: calculate the number of slots required for large MTU vifs Matt Wilson
2013-07-10  8:13     ` Wei Liu
2013-07-10 19:37       ` Wei Liu
2013-07-11  1:25         ` annie li
2013-07-11  5:14         ` [Xen-devel] " Matt Wilson
2013-07-11  6:01           ` annie li
2013-07-11 13:52             ` annie li
2013-07-12  8:49               ` Wei Liu
2013-07-12  9:19                 ` annie li
2013-07-18 11:47                   ` Ian Campbell
2013-07-11  8:46           ` Wei Liu
2013-07-16 10:08           ` annie li
2013-07-16 10:27             ` Wei Liu
2013-07-16 17:40               ` Matt Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130710074851.GH19798@zion.uk.xensource.com \
    --to=wei.liu2@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=annie.li@oracle.com \
    --cc=konrad.wilk@oracle.com \
    --cc=netdev@vger.kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).