From: David Miller <davem@davemloft.net>
To: annie.li@oracle.com
Cc: xen-devel@lists.xensource.com, netdev@vger.kernel.org,
Ian.Campbell@citrix.com, wei.liu2@citrix.com,
konrad.wilk@oracle.com, msw@amazon.com
Subject: Re: [PATCH v2 1/1] xen/netback: correctly calculate required slots of skb.
Date: Thu, 11 Jul 2013 13:03:14 -0700 (PDT) [thread overview]
Message-ID: <20130711.130314.2300492549661006309.davem@davemloft.net> (raw)
In-Reply-To: <1373447711-31303-1-git-send-email-annie.li@oracle.com>
From: Annie Li <annie.li@oracle.com>
Date: Wed, 10 Jul 2013 17:15:11 +0800
> When counting required slots for skb, netback directly uses DIV_ROUND_UP to get
> slots required by header data. This is wrong when offset in the page of header
> data is not zero, and is also inconsistent with following calculation for
> required slot in netbk_gop_skb.
>
> In netbk_gop_skb, required slots are calculated based on offset and len in page
> of header data. It is possible that required slots here is larger than the one
> calculated in earlier netbk_count_requests. This inconsistency directly results
> in rx_req_cons_peek and xen_netbk_rx_ring_full judgement are wrong.
>
> Then it comes to situation the ring is actually full, but netback thinks it is
> not and continues to create responses. This results in response overlaps request
> in the ring, then grantcopy gets wrong grant reference and throws out error,
> for example "(XEN) grant_table.c:1763:d0 Bad grant reference 2949120", the
> grant reference is invalid value here. Netback returns XEN_NETIF_RSP_ERROR(-1)
> to netfront when grant copy status is error, then netfront gets rx->status
> (the status is -1, not really data size now), and throws out error,
> "kernel: net eth1: rx->offset: 0, size: 4294967295". This issue can be reproduced
> by doing gzip/gunzip in nfs share with mtu = 9000, the guest would panic after
> running such test for a while.
>
> This patch is based on 3.10-rc7.
>
> Signed-off-by: Annie Li <annie.li@oracle.com>
A lot of discussion... will we have another respin of this patch or can I
get an ACK from Ian or someone else?
Thanks.
next prev parent reply other threads:[~2013-07-11 20:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 9:15 [PATCH v2 1/1] xen/netback: correctly calculate required slots of skb Annie Li
2013-07-11 2:18 ` David Miller
2013-07-11 2:48 ` [Xen-devel] " annie li
2013-07-11 19:04 ` David Miller
2013-07-11 8:11 ` Ian Campbell
2013-07-11 8:34 ` annie li
2013-07-11 9:47 ` Ian Campbell
2013-07-11 10:46 ` Annie
2013-07-11 10:59 ` Annie
2013-07-11 11:12 ` [Xen-devel] " Ian Campbell
2013-07-11 13:35 ` annie li
2013-07-11 20:03 ` David Miller [this message]
2013-07-11 21:12 ` Wei Liu
2013-07-16 9:00 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130711.130314.2300492549661006309.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ian.Campbell@citrix.com \
--cc=annie.li@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=msw@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).