netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Himanshu Madhani <himanshu.madhani@qlogic.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
	<Dept_NX_Linux_NIC_Driver@qlogic.com>
Subject: Re: [RFC] qlcnic: Enhance ethtool to display board temperature.
Date: Fri, 19 Jul 2013 09:11:28 -0700	[thread overview]
Message-ID: <20130719091128.068e5514@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1374206237-27233-1-git-send-email-himanshu.madhani@qlogic.com>

 
>  static int
> diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
> index 38dbafa..2012015 100644
> --- a/include/uapi/linux/ethtool.h
> +++ b/include/uapi/linux/ethtool.h
> @@ -101,6 +101,7 @@ struct ethtool_drvinfo {
>  	__u32	testinfo_len;
>  	__u32	eedump_len;	/* Size of data from ETHTOOL_GEEPROM (bytes) */
>  	__u32	regdump_len;	/* Size of data from ETHTOOL_GREGS (bytes) */
> +	__u32	board_temp;     /* board temperature */
>  };

The idea is good but a couple of comments.
1. you can't break userspace ABI for ethtool by adding elements.

2. There already exists a hardware monitoring subsystem in
   Linux and there are applications that use it (like SNMP. If you want this feature to
   be more than a developer toy, then it should use the existing subsystem API's.

  parent reply	other threads:[~2013-07-19 16:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-19  3:57 Himanshu Madhani
2013-07-19 15:06 ` Rick Jones
2013-07-19 17:59   ` Himanshu Madhani
2013-07-19 16:11 ` Stephen Hemminger [this message]
2013-07-19 18:00   ` Himanshu Madhani
2013-07-21 15:54 ` Ben Hutchings
2013-07-23 21:31   ` Himanshu Madhani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130719091128.068e5514@nehalam.linuxnetplumber.net \
    --to=stephen@networkplumber.org \
    --cc=Dept_NX_Linux_NIC_Driver@qlogic.com \
    --cc=davem@davemloft.net \
    --cc=himanshu.madhani@qlogic.com \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [RFC] qlcnic: Enhance ethtool to display board temperature.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).