netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Richter <tmricht@linux.vnet.ibm.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH 2/2 V2] macvlan fdb replace support
Date: Fri, 19 Jul 2013 09:18:55 -0700	[thread overview]
Message-ID: <20130719091855.6c763231@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1374247208-8226-2-git-send-email-tmricht@linux.vnet.ibm.com>

On Fri, 19 Jul 2013 17:20:08 +0200
Thomas Richter <tmricht@linux.vnet.ibm.com> wrote:

> Add support for iproute2 command 'bridge fdb replace ...'.
> The rtnletlink call back function ndo_fdb_add will be called
> with the NLM_F_REPLACE flag set.
> Simply return -EOPNOTSUP.
> 
> Resubmitted because net-next was closed last week.
> 
> Signed-off-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
> ---
>  drivers/net/macvlan.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
> index 18373b6..74907f5 100644
> --- a/drivers/net/macvlan.c
> +++ b/drivers/net/macvlan.c
> @@ -597,6 +597,9 @@ static int macvlan_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],
>  	if (!vlan->port->passthru)
>  		return -EOPNOTSUPP;
>  
> +	if (flags & NLM_F_REPLACE)
> +		return -EOPNOTSUPP;
> +
>  	if (is_unicast_ether_addr(addr))
>  		err = dev_uc_add_excl(dev, addr);
>  	else if (is_multicast_ether_addr(addr))

What about bridge that also uses netlink FDB interface?

  reply	other threads:[~2013-07-19 16:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-19 15:20 [PATCH 1/2 V2] vxlan fdb replace an existing entry Thomas Richter
2013-07-19 15:20 ` [PATCH 2/2 V2] macvlan fdb replace support Thomas Richter
2013-07-19 16:18   ` Stephen Hemminger [this message]
2013-07-22 13:16     ` Thomas-Mich Richter
2013-07-23 23:36   ` David Miller
2013-07-23 23:36 ` [PATCH 1/2 V2] vxlan fdb replace an existing entry David Miller
  -- strict thread matches above, loose matches on Subject: below --
2013-07-12  7:10 Thomas Richter
2013-07-12  7:10 ` [PATCH 2/2 V2] macvlan fdb replace support Thomas Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130719091855.6c763231@nehalam.linuxnetplumber.net \
    --to=stephen@networkplumber.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=tmricht@linux.vnet.ibm.com \
    --subject='Re: [PATCH 2/2 V2] macvlan fdb replace support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).