From: Steffen Klassert <steffen.klassert@secunet.com>
To: Fan Du <fan.du@windriver.com>
Cc: David Miller <davem@davemloft.net>,
nicolas.dichtel@6wind.com, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, jmorris@namei.org,
netdev@vger.kernel.org
Subject: Re: [RFC PATCH net-next] net: split rt_genid for ipv4 and ipv6
Date: Mon, 22 Jul 2013 12:53:55 +0200 [thread overview]
Message-ID: <20130722105355.GP3109@secunet.com> (raw)
In-Reply-To: <51ECC682.1030409@windriver.com>
On Mon, Jul 22, 2013 at 01:43:30PM +0800, Fan Du wrote:
>
> -static inline void rt_genid_bump(struct net *net)
> +#if IS_ENABLED(CONFIG_IPV6)
> +static inline int rt_genid_ipv6(struct net *net)
> {
> - atomic_inc(&net->rt_genid);
> + return atomic_read(&net->rt_genid_ipv6);
> +}
> +
> +static inline void rt_genid_bump_ipv6(struct net *net)
> +{
> + atomic_inc(&net->rt_genid_ipv6);
> +}
> +#endif
> +
I think this will introduce a compile error if ipv6 is
not enabled because you use rt_genid_bump_ipv6() in
the generic IPsec code.
> +static inline void rt_genid_bump_all(struct net *net)
> +{
> + atomic_inc(&net->rt_genid_ipv4);
> +#if IS_ENABLED(CONFIG_IPV6)
> + atomic_inc(&net->rt_genid_ipv6);
> +#endif
> }
>
Function is unused.
The rest looks ok.
next prev parent reply other threads:[~2013-07-22 10:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 3:22 [DISCUSSION] rt6i_genid Fan Du
2013-07-18 9:13 ` Nicolas Dichtel
2013-07-18 9:28 ` Fan Du
2013-07-18 15:12 ` Nicolas Dichtel
2013-07-19 0:01 ` Fan Du
2013-07-19 3:18 ` David Miller
2013-07-19 3:28 ` Fan Du
2013-07-19 3:31 ` David Miller
2013-07-19 7:50 ` Fan Du
2013-07-19 9:33 ` David Miller
2013-07-22 5:43 ` [RFC PATCH net-next] net: split rt_genid for ipv4 and ipv6 Fan Du
2013-07-22 10:53 ` Steffen Klassert [this message]
2013-07-22 20:40 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130722105355.GP3109@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=fan.du@windriver.com \
--cc=jmorris@namei.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).