From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Rick Jones <rick.jones2@hp.com>, netdev <netdev@vger.kernel.org>,
Yuchung Cheng <ycheng@google.com>,
Neal Cardwell <ncardwell@google.com>,
Michael Kerrisk <mtk.manpages@gmail.com>
Subject: Re: [PATCH v3 net-next 2/2] tcp: TCP_NOTSENT_LOWAT socket option
Date: Tue, 23 Jul 2013 05:52:02 +0200 [thread overview]
Message-ID: <20130723035202.GA32523@order.stressinduktion.org> (raw)
In-Reply-To: <1374550027.4990.141.camel@edumazet-glaptop>
On Mon, Jul 22, 2013 at 08:27:07PM -0700, Eric Dumazet wrote:
> Note this is not related to SO_SNDLOWAT (as SO_SNDLOWAT is
> defined as :
> Specify the minimum number of bytes in the buffer until
> the socket layer will pass the data to the protocol)
Oh, I had another understanding of SO_SNDLOWAT in my head: The minimum amount
of free write space in the socket buffer so that select/poll reports POLLOUT.
In my previous mail I was specifically referring to the optimization in
sk_stream_write_space() and not to the whole TCP_NOTSEND_LOWAT knob.
Thanks,
Hannes
next prev parent reply other threads:[~2013-07-23 3:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 3:27 [PATCH v3 net-next 2/2] tcp: TCP_NOTSENT_LOWAT socket option Eric Dumazet
2013-07-23 3:52 ` Hannes Frederic Sowa [this message]
2013-07-23 15:26 ` Rick Jones
2013-07-23 15:44 ` Eric Dumazet
2013-07-23 16:20 ` Rick Jones
2013-07-23 16:48 ` Eric Dumazet
2013-07-23 17:18 ` Eric Dumazet
2013-07-23 18:24 ` Yuchung Cheng
2013-07-25 0:55 ` David Miller
2013-07-23 19:19 Neal Cardwell
2013-07-23 19:28 Neal Cardwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130723035202.GA32523@order.stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=mtk.manpages@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).