netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Peter Wu <lekensteyn@gmail.com>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
	David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, nic_swsd@realtek.com
Subject: Re: r8169: remove "PHY reset until link up" log spam
Date: Tue, 23 Jul 2013 09:17:22 -0700	[thread overview]
Message-ID: <20130723091722.1e791f0c@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <2856794.AWy189S2qk@al>

On Tue, 23 Jul 2013 18:07:15 +0200
Peter Wu <lekensteyn@gmail.com> wrote:

> On Tuesday 23 July 2013 08:54:36 Stephen Hemminger wrote:
> > On Tue, 23 Jul 2013 11:55:57 +0200
> > 
> > Peter Wu <lekensteyn@gmail.com> wrote:
> > > This message was added in commit a7154cb8 (June 2004) and is printed
> > > every ten seconds when no cable is connected.
> > > 
> > > Signed-off-by: Peter Wu <lekensteyn@gmail.com>
> > > ---
> > > Using ethtool to silence *all* link warnings is still a manual
> > > operation, in my opinion not acceptable so let's remove this message.
> > > 
> > > The r8169 constantly resets the device when no link is connected,
> > > contrary the r8168 vendor driver which only resets the link when some
> > > PCI config fields have been modified. As the current reset logic in r8168
> > > seems to work for broken device (which I do not have have and therefore
> > > cannot test), I did not attempt to "clean this up".
> > > ---
> > > 
> > >  drivers/net/ethernet/realtek/r8169.c | 2 --
> > >  1 file changed, 2 deletions(-)
> > > 
> > > diff --git a/drivers/net/ethernet/realtek/r8169.c
> > > b/drivers/net/ethernet/realtek/r8169.c index 880015c..63f04af 100644
> > > --- a/drivers/net/ethernet/realtek/r8169.c
> > > +++ b/drivers/net/ethernet/realtek/r8169.c
> > > @@ -3689,8 +3689,6 @@ static void rtl_phy_work(struct rtl8169_private *tp)
> > > 
> > >  	if (tp->link_ok(ioaddr))
> > >  	
> > >  		return;
> > > 
> > > -	netif_warn(tp, link, tp->dev, "PHY reset until link up\n");
> > > -
> > > 
> > >  	tp->phy_reset_enable(tp);
> > >  
> > >  out_mod_timer:
> > Why not implement netif msg flag to allow user to control this?
> 
> Which user wants to get log spam every ten seconds? I see no purpose except 
> when a developer asks a user to turn this on, or except if you are a 
> developer. This message was added almost ten years ago, Realtek must certainly 
> have improved their hardware not to be so crappy? 
> 
> See also <http://marc.info/?l=linux-netdev&m=137452974325684&w=2> where David 
> Miller wrote:
> > In every case where this issue has popped up, we have decided that
> > printing messages when the cable is simply unplugged is very
> > undesirable.
> 
> Regards,
> Peter

I meant the general link up/down message, not the silly polling message

  reply	other threads:[~2013-07-23 16:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23  9:55 Peter Wu
2013-07-23 12:22 ` Sergei Shtylyov
2013-07-23 12:38   ` [PATCH v2] " Peter Wu
2013-07-23 20:23     ` Francois Romieu
2013-07-23 20:48       ` Peter Wu
2013-07-23 21:50         ` Francois Romieu
2013-07-23 15:54 ` Stephen Hemminger
2013-07-23 16:07   ` Peter Wu
2013-07-23 16:17     ` Stephen Hemminger [this message]
2013-07-23 21:18       ` Stephen Hemminger
2013-07-23 20:23     ` Francois Romieu
2013-07-23 20:59       ` Peter Wu
2013-07-23 21:51         ` Francois Romieu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130723091722.1e791f0c@nehalam.linuxnetplumber.net \
    --to=stephen@networkplumber.org \
    --cc=davem@davemloft.net \
    --cc=lekensteyn@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=romieu@fr.zoreil.com \
    --subject='Re: r8169: remove "PHY reset until link up" log spam' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).