netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] pktgen: Add UDPCSUM flag to support UDP checksums
Date: Tue, 23 Jul 2013 18:15:45 +0100	[thread overview]
Message-ID: <20130723171545.GB16761@casper.infradead.org> (raw)
In-Reply-To: <1374597252.3449.26.camel@edumazet-glaptop>

On 07/23/13 at 09:34am, Eric Dumazet wrote:
> > @@ -2747,11 +2755,31 @@ static struct sk_buff *fill_packet_ipv4(struct net_device *odev,
> >  	iph->frag_off = 0;
> >  	iplen = 20 + 8 + datalen;
> >  	iph->tot_len = htons(iplen);
> > -	iph->check = 0;
> > -	iph->check = ip_fast_csum((void *)iph, iph->ihl);
> 
> This seems not relevant to your patch.

I'll split this into a separate patch.

> What about IPv6 side ?

IPv6 is dead ;-) Just kidding, I'll add the bits in case someone
thinks otherwise.

      reply	other threads:[~2013-07-23 17:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23 16:20 Thomas Graf
2013-07-23 16:34 ` Eric Dumazet
2013-07-23 17:15   ` Thomas Graf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130723171545.GB16761@casper.infradead.org \
    --to=tgraf@suug.ch \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH net-next] pktgen: Add UDPCSUM flag to support UDP checksums' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).