netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Francois Romieu <romieu@fr.zoreil.com>
To: Peter Wu <lekensteyn@gmail.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>, netdev@vger.kernel.org
Subject: Re: [PATCH v2 1/2] realtek: convert to per-chip mask
Date: Tue, 23 Jul 2013 22:24:37 +0200	[thread overview]
Message-ID: <20130723202437.GC31567@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <1602191.cqZWCGFrek@al>

Peter Wu <lekensteyn@gmail.com> :
[...]
> diff --git a/realtek.c b/realtek.c
> index c3d7ae5..5a1fba7 100644
> --- a/realtek.c
> +++ b/realtek.c
[...]
> @@ -35,36 +32,62 @@ enum chip_type {
>  	RTL8100E2,
>  };
>  
> -enum {
> -	chip_type_mask = HW_REVID(1, 1, 1, 1, 1, 1, 1, 1)
> +static const char * const chip_names[] = {
> +	[RTL8139] = "RTL-8139",
> +	[RTL8139_K] = "RTL-8139-K",
> +	[RTL8139A] = "RTL-8139A",
> +	[RTL8139A_G] = "RTL-8139A-G",
> +	[RTL8139B] = "RTL-8139B",
> +	[RTL8130] = "RTL-8130",
> +	[RTL8139C] = "RTL-8139C",
> +	[RTL8100] = "RTL-8100",
> +	[RTL8100B_8139D] = "RTL-8100B/8139D",
> +	[RTL8139C] = "RTL-8139C+",
> +	[RTL8101] = "RTL-8101",
> +
> +	/* chips not handled by 8139too/8139cp module */
> +	[RTL8169] = "RTL-8169",
> +	[RTL8169S] = "RTL-8169S",
> +	[RTL8110S] = "RTL-8110S",
> +	[RTL8169_8110SB] = "RTL-8169/8110SB",
> +	[RTL8169_8110SCd] = "RTL-8169/8110SCd",
> +	[RTL8169_8110SCe] = "RTL-8169/8110SCe",
> +	[RTL8168_8111Bb] = "RTL-8168/8111Bb",
> +	[RTL8168_8111Bef] = "RTL-8168/8111Bef",
> +	[RTL8101Ebc] = "RTL-8101Ebc",
> +	[RTL8100E1] = "RTL-8100E(1)",
> +	[RTL8100E2] = "RTL-8100E(2)",

Tab after equal may be.

The "RTL-" prefix string could be shared.

-- 
Ueimor

  reply	other threads:[~2013-07-23 20:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23  8:51 [ethtool] Add new Realtek devices Peter Wu
2013-07-23  8:51 ` [PATCH 1/2] realtek: convert to per-chip mask Peter Wu
2013-07-23 17:56   ` Ben Hutchings
2013-07-23  8:51 ` [PATCH 2/2] realtek: update devices to 3.11 Peter Wu
2013-07-23 18:04 ` [PATCH v2 " Peter Wu
2013-07-23 18:05 ` [PATCH v2 1/2] realtek: convert to per-chip mask Peter Wu
2013-07-23 20:24   ` Francois Romieu [this message]
2013-07-23 21:03     ` Peter Wu
2013-07-23 20:25 ` [ethtool] Add new Realtek devices Francois Romieu
2013-07-23 21:08   ` Peter Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130723202437.GC31567@electric-eye.fr.zoreil.com \
    --to=romieu@fr.zoreil.com \
    --cc=bhutchings@solarflare.com \
    --cc=lekensteyn@gmail.com \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH v2 1/2] realtek: convert to per-chip mask' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).