netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Francois Romieu <romieu@fr.zoreil.com>
To: Peter Wu <lekensteyn@gmail.com>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, nic_swsd@realtek.com
Subject: Re: [PATCH v2] r8169: remove "PHY reset until link up" log spam
Date: Tue, 23 Jul 2013 23:50:58 +0200	[thread overview]
Message-ID: <20130723215058.GA2375@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <7176161.ct75f9bf8d@al>

Peter Wu <lekensteyn@gmail.com> :
[...]
> I have not really considered runtime PM before, aren't the ethtool
> operations actually broken with runtime PM enabled ? Or does the ethtool
> core take care of waking devices (which I doubt) ? I don't see any attempt
> to wake devices in the r8169 ethtool operations.

ethtool core bails out.

See dev_ethtool, netif_device_present, rtl8169_net_suspend and
netif_device_detach.

[...]
> > You have the implicit ack of David, so please keep the facts right.
> I am not trying to hide details, before I send the third revision of third 
> commit message, what other details may I have overseen ?

Use netif_dbg instead of removing the message ?

> If you want to, you can also create a patch with an appropriate commit
> message, I don't mind.

[...]
- when no cable is connected.
+ when no cable is connected and runtime power management is disabled.

That's it. Your patch, your credit.

-- 
Ueimor

  reply	other threads:[~2013-07-23 21:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23  9:55 Peter Wu
2013-07-23 12:22 ` Sergei Shtylyov
2013-07-23 12:38   ` [PATCH v2] " Peter Wu
2013-07-23 20:23     ` Francois Romieu
2013-07-23 20:48       ` Peter Wu
2013-07-23 21:50         ` Francois Romieu [this message]
2013-07-23 15:54 ` Stephen Hemminger
2013-07-23 16:07   ` Peter Wu
2013-07-23 16:17     ` Stephen Hemminger
2013-07-23 21:18       ` Stephen Hemminger
2013-07-23 20:23     ` Francois Romieu
2013-07-23 20:59       ` Peter Wu
2013-07-23 21:51         ` Francois Romieu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130723215058.GA2375@electric-eye.fr.zoreil.com \
    --to=romieu@fr.zoreil.com \
    --cc=davem@davemloft.net \
    --cc=lekensteyn@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    --subject='Re: [PATCH v2] r8169: remove "PHY reset until link up" log spam' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).