netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] bgmac: make bgmac depend on bcm47xx
@ 2013-07-23 21:28 Hauke Mehrtens
  2013-07-24  1:08 ` Stephen Rothwell
  0 siblings, 1 reply; 5+ messages in thread
From: Hauke Mehrtens @ 2013-07-23 21:28 UTC (permalink / raw)
  To: davem; +Cc: zajec5, netdev, linville, linux-next, sfr, Hauke Mehrtens

bgmac uses bcm47xx_nvram.h which is only available when BCM47XX was
selected. Earlier BCMA_HOST_SOC depended on BCM47XX so this was not
build on any other archs, but that changed. We should modify this
driver to get access to the nvram or the variables through platform
data.

This fixes a build problem in linux-next reported by Stephen Rothwell:

drivers/net/ethernet/broadcom/bgmac.c:19:27: fatal error: bcm47xx_nvram.h: No such file or directory
 #include <bcm47xx_nvram.h>
                           ^

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/broadcom/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
index 52c9603..2fa5b86 100644
--- a/drivers/net/ethernet/broadcom/Kconfig
+++ b/drivers/net/ethernet/broadcom/Kconfig
@@ -130,7 +130,7 @@ config BNX2X_SRIOV
 
 config BGMAC
 	tristate "BCMA bus GBit core support"
-	depends on BCMA_HOST_SOC && HAS_DMA
+	depends on BCMA_HOST_SOC && HAS_DMA && BCM47XX
 	select PHYLIB
 	---help---
 	  This driver supports GBit MAC and BCM4706 GBit MAC cores on BCMA bus.
-- 
1.7.10.4

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] bgmac: make bgmac depend on bcm47xx
  2013-07-23 21:28 [PATCH] bgmac: make bgmac depend on bcm47xx Hauke Mehrtens
@ 2013-07-24  1:08 ` Stephen Rothwell
  2013-07-24  3:26   ` Stephen Rothwell
  2013-07-24 13:54   ` John W. Linville
  0 siblings, 2 replies; 5+ messages in thread
From: Stephen Rothwell @ 2013-07-24  1:08 UTC (permalink / raw)
  To: Hauke Mehrtens; +Cc: davem, zajec5, netdev, linville, linux-next

[-- Attachment #1: Type: text/plain, Size: 910 bytes --]

Hi,

On Tue, 23 Jul 2013 23:28:49 +0200 Hauke Mehrtens <hauke@hauke-m.de> wrote:
>
> bgmac uses bcm47xx_nvram.h which is only available when BCM47XX was
> selected. Earlier BCMA_HOST_SOC depended on BCM47XX so this was not
> build on any other archs, but that changed. We should modify this
> driver to get access to the nvram or the variables through platform
> data.
> 
> This fixes a build problem in linux-next reported by Stephen Rothwell:
> 
> drivers/net/ethernet/broadcom/bgmac.c:19:27: fatal error: bcm47xx_nvram.h: No such file or directory
>  #include <bcm47xx_nvram.h>
>                            ^
> 
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>

This patch really needs to go to John as the patch that exposes the
breakage is in his tree.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] bgmac: make bgmac depend on bcm47xx
  2013-07-24  1:08 ` Stephen Rothwell
@ 2013-07-24  3:26   ` Stephen Rothwell
  2013-07-24 13:54   ` John W. Linville
  1 sibling, 0 replies; 5+ messages in thread
From: Stephen Rothwell @ 2013-07-24  3:26 UTC (permalink / raw)
  To: Hauke Mehrtens; +Cc: davem, zajec5, netdev, linville, linux-next

[-- Attachment #1: Type: text/plain, Size: 1091 bytes --]

Hi,

On Wed, 24 Jul 2013 11:08:58 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Tue, 23 Jul 2013 23:28:49 +0200 Hauke Mehrtens <hauke@hauke-m.de> wrote:
> >
> > bgmac uses bcm47xx_nvram.h which is only available when BCM47XX was
> > selected. Earlier BCMA_HOST_SOC depended on BCM47XX so this was not
> > build on any other archs, but that changed. We should modify this
> > driver to get access to the nvram or the variables through platform
> > data.
> > 
> > This fixes a build problem in linux-next reported by Stephen Rothwell:
> > 
> > drivers/net/ethernet/broadcom/bgmac.c:19:27: fatal error: bcm47xx_nvram.h: No such file or directory
> >  #include <bcm47xx_nvram.h>
> >                            ^
> > 
> > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> 
> This patch really needs to go to John as the patch that exposes the
> breakage is in his tree.

I applied this to the wireless-next tree merge today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] bgmac: make bgmac depend on bcm47xx
  2013-07-24  1:08 ` Stephen Rothwell
  2013-07-24  3:26   ` Stephen Rothwell
@ 2013-07-24 13:54   ` John W. Linville
  2013-07-24 19:40     ` David Miller
  1 sibling, 1 reply; 5+ messages in thread
From: John W. Linville @ 2013-07-24 13:54 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Hauke Mehrtens, davem, zajec5, netdev, linux-next

On Wed, Jul 24, 2013 at 11:08:58AM +1000, Stephen Rothwell wrote:
> Hi,
> 
> On Tue, 23 Jul 2013 23:28:49 +0200 Hauke Mehrtens <hauke@hauke-m.de> wrote:
> >
> > bgmac uses bcm47xx_nvram.h which is only available when BCM47XX was
> > selected. Earlier BCMA_HOST_SOC depended on BCM47XX so this was not
> > build on any other archs, but that changed. We should modify this
> > driver to get access to the nvram or the variables through platform
> > data.
> > 
> > This fixes a build problem in linux-next reported by Stephen Rothwell:
> > 
> > drivers/net/ethernet/broadcom/bgmac.c:19:27: fatal error: bcm47xx_nvram.h: No such file or directory
> >  #include <bcm47xx_nvram.h>
> >                            ^
> > 
> > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> 
> This patch really needs to go to John as the patch that exposes the
> breakage is in his tree.

I'll merge this one -- OK, Dave?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] bgmac: make bgmac depend on bcm47xx
  2013-07-24 13:54   ` John W. Linville
@ 2013-07-24 19:40     ` David Miller
  0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2013-07-24 19:40 UTC (permalink / raw)
  To: linville; +Cc: sfr, hauke, zajec5, netdev, linux-next

From: "John W. Linville" <linville@tuxdriver.com>
Date: Wed, 24 Jul 2013 09:54:12 -0400

> On Wed, Jul 24, 2013 at 11:08:58AM +1000, Stephen Rothwell wrote:
>> Hi,
>> 
>> On Tue, 23 Jul 2013 23:28:49 +0200 Hauke Mehrtens <hauke@hauke-m.de> wrote:
>> >
>> > bgmac uses bcm47xx_nvram.h which is only available when BCM47XX was
>> > selected. Earlier BCMA_HOST_SOC depended on BCM47XX so this was not
>> > build on any other archs, but that changed. We should modify this
>> > driver to get access to the nvram or the variables through platform
>> > data.
>> > 
>> > This fixes a build problem in linux-next reported by Stephen Rothwell:
>> > 
>> > drivers/net/ethernet/broadcom/bgmac.c:19:27: fatal error: bcm47xx_nvram.h: No such file or directory
>> >  #include <bcm47xx_nvram.h>
>> >                            ^
>> > 
>> > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
>> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>> 
>> This patch really needs to go to John as the patch that exposes the
>> breakage is in his tree.
> 
> I'll merge this one -- OK, Dave?

No problem.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-07-24 19:41 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-23 21:28 [PATCH] bgmac: make bgmac depend on bcm47xx Hauke Mehrtens
2013-07-24  1:08 ` Stephen Rothwell
2013-07-24  3:26   ` Stephen Rothwell
2013-07-24 13:54   ` John W. Linville
2013-07-24 19:40     ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).