netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RESEND PATCH net-next] net ipv6: Remove rebundant rt6i_nsiblings initialization
@ 2013-07-22  6:20 Fan Du
  2013-07-24 21:26 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Fan Du @ 2013-07-22  6:20 UTC (permalink / raw)
  To: davem; +Cc: nicolas.dichtel, yoshfuji, jmorris, hannes, netdev

Seting rt->rt6i_nsiblings to zero is rebundant, because above memset
zeroed the rest of rt excluding the first dst memember.

Signed-off-by: Fan Du <fan.du@windriver.com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
Cc: James Morris <jmorris@namei.org>
---
 net/ipv6/route.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 45ca9af..ce96163 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -285,7 +285,6 @@ static inline struct rt6_info *ip6_dst_alloc(struct net *net,
 		rt6_init_peer(rt, table ? &table->tb6_peers : net->ipv6.peers);
 		rt->rt6i_genid = rt_genid_ipv6(net);
 		INIT_LIST_HEAD(&rt->rt6i_siblings);
-		rt->rt6i_nsiblings = 0;
 	}
 	return rt;
 }
-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [RESEND PATCH net-next] net ipv6: Remove rebundant rt6i_nsiblings initialization
  2013-07-22  6:20 [RESEND PATCH net-next] net ipv6: Remove rebundant rt6i_nsiblings initialization Fan Du
@ 2013-07-24 21:26 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-07-24 21:26 UTC (permalink / raw)
  To: fan.du; +Cc: nicolas.dichtel, yoshfuji, jmorris, hannes, netdev

From: Fan Du <fan.du@windriver.com>
Date: Mon, 22 Jul 2013 14:20:12 +0800

> Seting rt->rt6i_nsiblings to zero is rebundant, because above memset
> zeroed the rest of rt excluding the first dst memember.
> 
> Signed-off-by: Fan Du <fan.du@windriver.com>
> Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-07-24 21:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-22  6:20 [RESEND PATCH net-next] net ipv6: Remove rebundant rt6i_nsiblings initialization Fan Du
2013-07-24 21:26 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).