netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: lekensteyn@gmail.com
Cc: netdev@vger.kernel.org, romieu@fr.zoreil.com, nic_swsd@realtek.com
Subject: Re: [PATCH net v2 1/1] r8169: fix lockdep warning when removing interface
Date: Wed, 24 Jul 2013 15:43:37 -0700 (PDT)	[thread overview]
Message-ID: <20130724.154337.318987942705079482.davem@davemloft.net> (raw)
In-Reply-To: <3190648.uJuPIZ6zlh@al>

From: Peter Wu <lekensteyn@gmail.com>
Date: Mon, 22 Jul 2013 09:53:30 +0200

> The work queue is initialised in rtl_open (when the interface goes up),
> but canceled in rtl_remove_one (when the PCI device gets removed). If
> the network interface is not brought up, then the work queue struct is
> not initialised. When the device is removed, the attempt to cancel the
> uninitialised work queue causes a lockdep warning.
> 
> This patch fixes the issue by moving cancel_work_sync to rtl_close (to
> match rtl_open). (Note that rtl_close is also called via
> unregister_netdev in rtl_remove_one.)
> 
> Signed-off-by: Peter Wu <lekensteyn@gmail.com>
> Acked-by: Francois Romieu <romieu@fr.zoreil.com>

Applied, thanks.

      reply	other threads:[~2013-07-24 22:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-22  7:53 Peter Wu
2013-07-24 22:43 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130724.154337.318987942705079482.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=lekensteyn@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=romieu@fr.zoreil.com \
    --subject='Re: [PATCH net v2 1/1] r8169: fix lockdep warning when removing interface' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).