netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dingtianhong@huawei.com
Cc: fubar@us.ibm.com, andy@greyhouse.net, netdev@vger.kernel.org
Subject: Re: [PATCH 1/4 v2] bonding: don't call slave_xxx_netpoll under spinlocks
Date: Wed, 24 Jul 2013 17:45:47 -0700 (PDT)	[thread overview]
Message-ID: <20130724.174547.131365101717202321.davem@davemloft.net> (raw)
In-Reply-To: <51EE2FE7.4040605@huawei.com>

From: Ding Tianhong <dingtianhong@huawei.com>
Date: Tue, 23 Jul 2013 15:25:27 +0800

> The slave_xxx_netpoll will call synchronize_rcu_bh(),
> so the function may schedule and sleep, it should't be
> called under spinlocks.
> 
> bond_netpoll_setup() and bond_netpoll_cleanup() are always
> protected by rtnl lock, it is no need to take the read lock,
> as the slave list couldn't be changed outside rtnl lock.
> 
> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>

Applied.

      reply	other threads:[~2013-07-25  0:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23  7:25 Ding Tianhong
2013-07-25  0:45 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130724.174547.131365101717202321.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andy@greyhouse.net \
    --cc=dingtianhong@huawei.com \
    --cc=fubar@us.ibm.com \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH 1/4 v2] bonding: don'\''t call slave_xxx_netpoll under spinlocks' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).