netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 4/4 v2] bonding: bond_sysfs.c checkpatch cleanup
@ 2013-07-23  7:25 Ding Tianhong
  2013-07-25  0:46 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Ding Tianhong @ 2013-07-23  7:25 UTC (permalink / raw)
  To: Jay Vosburgh, Andy Gospodarek, David S. Miller, Netdev

net/bonding/bond_sysfs.c:1302: ERROR: else should follow close brace '}'
net/bonding/bond_sysfs.c:1314: ERROR: else should follow close brace '}'

Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Cc: Jay Vosburgh <fubar@us.ibm.com>
Cc: Andy Gospodarek <andy@greyhouse.net>
---
 drivers/net/bonding/bond_sysfs.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c
index 8a5a6a3..ae02c19 100644
--- a/drivers/net/bonding/bond_sysfs.c
+++ b/drivers/net/bonding/bond_sysfs.c
@@ -1302,8 +1302,7 @@ static ssize_t bonding_store_active_slave(struct device *d,
 					bond->dev->name,
 					slave->dev->name);
 				goto out;
-			}
-			else {
+			} else {
 				if ((new_active) &&
 				    (old_active) &&
 				    (new_active->link == BOND_LINK_UP) &&
@@ -1314,8 +1313,7 @@ static ssize_t bonding_store_active_slave(struct device *d,
 						slave->dev->name);
 					bond_change_active_slave(bond,
 								 new_active);
-				}
-				else {
+				} else {
 					pr_info("%s: Could not set %s as"
 						" active slave; either %s is"
 						" down or the link is down.\n",
-- 
1.8.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 4/4 v2] bonding: bond_sysfs.c checkpatch cleanup
  2013-07-23  7:25 [PATCH 4/4 v2] bonding: bond_sysfs.c checkpatch cleanup Ding Tianhong
@ 2013-07-25  0:46 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-07-25  0:46 UTC (permalink / raw)
  To: dingtianhong; +Cc: fubar, andy, netdev

From: Ding Tianhong <dingtianhong@huawei.com>
Date: Tue, 23 Jul 2013 15:25:32 +0800

> net/bonding/bond_sysfs.c:1302: ERROR: else should follow close brace '}'
> net/bonding/bond_sysfs.c:1314: ERROR: else should follow close brace '}'
> 
> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-07-25  0:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-23  7:25 [PATCH 4/4 v2] bonding: bond_sysfs.c checkpatch cleanup Ding Tianhong
2013-07-25  0:46 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).