netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eli Cohen <eli@dev.mellanox.co.il>
To: Dan Carpenter <dan.carpenter@oracle.com>, moshel@mellanox.com
Cc: Eli Cohen <eli@mellanox.com>,
	netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch] mlx5: use after free in mlx5_cmd_comp_handler()
Date: Wed, 24 Jul 2013 19:35:44 +0300	[thread overview]
Message-ID: <20130724163544.GA29427@mtldesk30> (raw)
In-Reply-To: <20130722080201.GG14617@longonot.mountain>

This race has been spotted and fixed by Moshe Lazer two weeks ago.
Anyways,

Acked by Eli Cohen <eli@mellanox.com>

On Mon, Jul 22, 2013 at 11:02:01AM +0300, Dan Carpenter wrote:
> We can't dereference "ent" after passing it to free_cmd().
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> index 205753a..4037406 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> @@ -1113,7 +1113,13 @@ void mlx5_cmd_comp_handler(struct mlx5_core_dev *dev, unsigned long vector)
>  
>  	for (i = 0; i < (1 << cmd->log_sz); i++) {
>  		if (test_bit(i, &vector)) {
> +			struct semaphore *sem;
> +
>  			ent = cmd->ent_arr[i];
> +			if (ent->page_queue)
> +				sem = &cmd->pages_sem;
> +			else
> +				sem = &cmd->sem;
>  			ktime_get_ts(&ent->ts2);
>  			memcpy(ent->out->first.data, ent->lay->out, sizeof(ent->lay->out));
>  			dump_command(dev, ent, 0);
> @@ -1136,10 +1142,7 @@ void mlx5_cmd_comp_handler(struct mlx5_core_dev *dev, unsigned long vector)
>  			} else {
>  				complete(&ent->done);
>  			}
> -			if (ent->page_queue)
> -				up(&cmd->pages_sem);
> -			else
> -				up(&cmd->sem);
> +			up(sem);
>  		}
>  	}
>  }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2013-07-24 16:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-22  8:02 Dan Carpenter
2013-07-24 16:35 ` Eli Cohen [this message]
2013-07-24 22:45   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130724163544.GA29427@mtldesk30 \
    --to=eli@dev.mellanox.co.il \
    --cc=dan.carpenter@oracle.com \
    --cc=eli@mellanox.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=moshel@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [patch] mlx5: use after free in mlx5_cmd_comp_handler()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).