From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH v2 net-next] net/sctp: Refactor SCTP skb checksum computation Date: Thu, 25 Jul 2013 14:24:38 +0900 Message-ID: <20130725052437.GB25854@verge.net.au> References: <1374717125-28969-1-git-send-email-joe@wand.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Joe Stringer , davem@davemloft.net, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, lvs-devel@vger.kernel.org, pablo@netfilter.org, jesse@nicira.com To: Julian Anastasov Return-path: Content-Disposition: inline In-Reply-To: Sender: lvs-devel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, Jul 25, 2013 at 08:08:11AM +0300, Julian Anastasov wrote: > > Hello, > > On Thu, 25 Jul 2013, Joe Stringer wrote: > > > This patch consolidates the SCTP checksum calculation code from various > > places to a single new function, sctp_compute_cksum(skb, offset). > > > > Signed-off-by: Joe Stringer > > --- > > v2: > > * Use skb->data + offset for start position of checksum calculation > > * Fix existing bug in sctp_csum_check() where the incorrect offset was used > > * Remove redundant variable in sctp_nat_csum() > > v2 looks good to me, thanks! > > Reviewed-by: Julian Anastasov IPVS portion: Acked-by: Simon Horman Dave, could you consider taking this through net-next? > > --- > > include/net/sctp/checksum.h | 15 +++++++++++++++ > > net/netfilter/ipvs/ip_vs_proto_sctp.c | 23 +++-------------------- > > net/netfilter/nf_nat_proto_sctp.c | 8 +------- > > net/sctp/input.c | 10 +--------- > > 4 files changed, 20 insertions(+), 36 deletions(-) > > Regards > > -- > Julian Anastasov >