From: Dominique Martinet <dominique.martinet@cea.fr>
To: David Miller <davem@davemloft.net>
Cc: pebolle@tiscali.nl, lucho@ionkov.net, ericvh@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
andi@etezian.org, v9fs-developer@lists.sourceforge.net,
rminnich@sandia.gov
Subject: Re: [V9fs-developer] [PATCH] net: trans_rdma: remove unused function
Date: Thu, 25 Jul 2013 08:14:11 +0200 [thread overview]
Message-ID: <20130725061411.GA8579@nautica> (raw)
In-Reply-To: <20130724.164514.393667021861625699.davem@davemloft.net>
Hi,
David Miller wrote on Wed, Jul 24, 2013 :
> From: Paul Bolle <pebolle@tiscali.nl>
> Date: Thu, 25 Jul 2013 01:09:47 +0200
> > After this patch one might as well revert the rest of commit
> > 80b45261a0b2 ("9P: Add cancelled() to the transport functions.") too. It
> > seems the entire cancelled callback stuff is now pointless.
> >
> > As I already asked in https://lkml.org/lkml/2013/7/15/87 : did that
> > commit "forget to actually hook up rdma_cancelled() into
> > p9_rdma_trans()?". It does look so to me.
>
> If nobody responds to this in the next day or so, feel free to send me
> a patch which rips it all out.
>
> No response means they don't care, and neither, therefore, should we.
Well, I do care - but I couldn't find where the trans->cancelled member
function was supposed to be called anyway...
So adding it to the struct and fixing the warning is well and fine, but
if it's still never called in the end I don't see much point and there's
nothing to test.
It's on my loooong todo list of things to look at, but as no other reply
came and the patch was never picked up it kind of dropped in priority.
I'll have another look next week
I guess the worst that could happen would be submitting the
rdma_cancelled function again when this is sorted out :)
Regards,
--
Dominique Martinet
next prev parent reply other threads:[~2013-07-25 6:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 12:59 [PATCH] net: trans_rdma: remove unused function Andi Shyti
2013-07-24 22:46 ` David Miller
2013-07-24 23:09 ` Paul Bolle
2013-07-24 23:45 ` David Miller
2013-07-25 6:14 ` Dominique Martinet [this message]
2013-07-25 6:48 ` [V9fs-developer] " Dominique Martinet
2013-07-25 8:27 ` Andi Shyti
2013-07-25 8:35 ` David Miller
[not found] ` <CAFkjPTm1FH24EfWMDrXTh7DmU8WAb0ji-jkUgkayqMzfWj9O0A@mail.gmail.com>
2013-07-25 19:05 ` Dominique Martinet
2013-07-26 7:01 ` Dominique Martinet
[not found] ` <CAFkjPTkr5JYf6qc=pjcG8rSoocFekU-cTw450SujTvpCp33cyw@mail.gmail.com>
2013-07-26 15:17 ` Dominique Martinet
2013-07-25 8:54 ` [PATCH] 9p: client: remove unused code and any reference to "cancelled" function Andi Shyti
2013-07-25 8:57 ` Andi Shyti
2013-07-30 22:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130725061411.GA8579@nautica \
--to=dominique.martinet@cea.fr \
--cc=andi@etezian.org \
--cc=davem@davemloft.net \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=rminnich@sandia.gov \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).