From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Stefan Tomanek <stefan.tomanek@wertarbyte.de>
Cc: netdev@vger.kernel.org, Andrew Collins <bsderandrew@gmail.com>
Subject: Re: [PATCH] fib_rules: add .suppress operation
Date: Fri, 26 Jul 2013 19:05:56 +0200 [thread overview]
Message-ID: <20130726170556.GA11434@order.stressinduktion.org> (raw)
In-Reply-To: <20130726104657.GF10216@zirkel.wertarbyte.de>
On Fri, Jul 26, 2013 at 12:46:57PM +0200, Stefan Tomanek wrote:
> if (err != -EAGAIN) {
> + if (ops->suppress && ops->suppress(rule, arg)) {
> + continue;
> + }
> if ((arg->flags & FIB_LOOKUP_NOREF) ||
> likely(atomic_inc_not_zero(&rule->refcnt))) {
> arg->rule = rule;
>
> [...]
>
> +static int fib6_rule_suppress(struct fib_rule *rule, struct fib_lookup_arg *arg) {
> + struct rt6_info *rt = (struct rt6_info *) arg->result;
> + /*
> + * do not accept result if the route does
> + * not meet the required prefix length
> + */
> + if (rt->rt6i_dst.plen < rule->table_prefixlen_min) {
> + return 1;
> + }
> + return 0;
> +}
Urks, fib6_rule_action is broken. The switch (rule->action) does update the rt
entry but does not signal the correct error code to stop iterating the rules
in case it finds a blackhole, prohibit etc. action (it always signals
-EAGAIN).
A change in this logic could have impact to your patch as I currently
don't know how the null handling of arg->result will turn out. IPv6 does not
preinitialize arg->result as IPv4 does.
I am looking for a solution.
Thanks,
Hannes
next prev parent reply other threads:[~2013-07-26 17:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 22:02 [PATCH] fib_rules: add minimum prefix length Stefan Tomanek
2013-07-23 22:38 ` Stephen Hemminger
2013-07-23 22:52 ` Stefan Tomanek
2013-07-24 2:14 ` Hannes Frederic Sowa
2013-07-24 7:57 ` Stefan Tomanek
2013-07-25 16:29 ` Stefan Tomanek
2013-07-25 17:43 ` [PATCH] fib_rules/fib6rules: " Stefan Tomanek
2013-07-25 18:17 ` [PATCH] fib_rules: " Hannes Frederic Sowa
2013-07-25 18:28 ` Stefan Tomanek
2013-07-25 21:46 ` Andrew Collins
2013-07-25 22:11 ` Stefan Tomanek
2013-07-26 10:46 ` [PATCH] fib_rules: add .suppress operation Stefan Tomanek
2013-07-26 17:05 ` Hannes Frederic Sowa [this message]
2013-07-27 6:08 ` Hannes Frederic Sowa
2013-07-27 6:26 ` Hannes Frederic Sowa
2013-07-27 7:07 ` Hannes Frederic Sowa
2013-07-27 10:21 ` Stefan Tomanek
2013-07-27 15:10 ` Hannes Frederic Sowa
2013-07-28 10:36 ` Stefan Tomanek
2013-07-30 6:52 ` [PATCH v2 1/2] fib6_rules: make error handling consistent with IPv4 Stefan Tomanek
2013-07-30 6:53 ` [PATCH v2 2/2] fib_rules: add .suppress operation Stefan Tomanek
2013-07-30 7:03 ` David Miller
2013-07-30 7:23 ` Stefan Tomanek
2013-07-30 7:34 ` David Miller
2013-07-30 7:46 ` [PATCH v3] " Stefan Tomanek
2013-07-31 22:13 ` David Miller
2013-08-01 0:24 ` Stefan Tomanek
2013-08-01 0:26 ` David Miller
2013-08-01 0:17 ` [PATCH v4] " Stefan Tomanek
2013-08-01 0:27 ` David Miller
2013-08-01 1:26 ` Stefan Tomanek
2013-08-01 5:35 ` Hannes Frederic Sowa
2013-07-26 10:54 ` [PATCH] fib_rules: add minimum prefix length Stefan Tomanek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130726170556.GA11434@order.stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=bsderandrew@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stefan.tomanek@wertarbyte.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).