From: David Miller <davem@davemloft.net>
To: jasowang@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
basil.gor@gmail.com, mst@redhat.com
Subject: Re: [PATCH net-next V2] tuntap: hardware vlan tx support
Date: Sat, 27 Jul 2013 20:09:40 -0700 (PDT) [thread overview]
Message-ID: <20130727.200940.1407377271115722165.davem@davemloft.net> (raw)
In-Reply-To: <1374728433-19843-1-git-send-email-jasowang@redhat.com>
From: Jason Wang <jasowang@redhat.com>
Date: Thu, 25 Jul 2013 13:00:33 +0800
> Inspired by commit f09e2249c4f5c7c13261ec73f5a7807076af0c8e (macvtap: restore
> vlan header on user read). This patch adds hardware vlan tx support for
> tuntap. This is done by copying vlan header directly into userspace in
> tun_put_user() instead of doing it through __vlan_put_tag() in
> dev_hard_start_xmit(). This eliminates one unnecessary memmove() in
> vlan_insert_tag() for 802.1ad and 802.1q traffic.
>
> pktgen test shows about 20% improvement for 802.1q traffic:
>
> Before:
> 662149pps 317Mb/sec (317831520bps) errors: 0
> After:
> 801033pps 384Mb/sec (384495840bps) errors: 0
>
> Cc: Basil Gor <basil.gor@gmail.com>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Applied, thanks Jason.
prev parent reply other threads:[~2013-07-28 3:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 5:00 [PATCH net-next V2] tuntap: hardware vlan tx support Jason Wang
2013-07-28 3:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130727.200940.1407377271115722165.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=basil.gor@gmail.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).